1665414 - Support for docker-image definitions under comm/taskgraph/docker

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

Be able to use docker-image definitions under comm/taskgraph/docker and taskgraph/docker for Thunderbird builds. This will allow Thunderbird to iterate faster when working on Snap and Flatpak builds.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1665414 - Use image_path to locate context path in docker_image transform. r?#taskgraph-reviewers

This change is to facilitate defining docker-images in comm/taskcluster/docker. At the
moment this is not possible due to how 'context_path' is set.

taskgraph.docker.util is already imported by the transform code, so it can make use of
the existing image_path function. image_path return an absolute_path, while some of the
consumers of context_path expect a path that's relative to topsrcdir.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1665414 - Make docker image_paths extendable by projects. r?#taskgraph-reviewers

Replace the memoized dictionary that image_path uses as storage with a Mapping
object. It's equipped with a register function to allow Thunderbird to add it's own
docker image jobs and context path.

Depends on D92702

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1665414 - Move tb-debian-mingw docker-image definition to Thunderbird repo. r?#taskgraph-reviewers

This docker image was created for Thunderbird and is unavailable for Firefox
builds.

Depends on D92703

Comment 4

[Rob Lemley [:rjl]]

Attachment: Bug 1665414 - Allow for Docker images to be defined in comm/taskcluster/docker.

Docker image context directories go under comm/taskcluster/docker and must be
defined in comm/taskcluster/ci/docker-image/docker-image.yml in order for
the decision task to find them properly.

Comment 5

[Rob Lemley [:rjl]]

Attachment: Bug 1665414 - Move tb-debian-mingw docker-image definition to comm repo.

Depends on D92705

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38b2b48db658
Use image_path to locate context path in docker_image transform.  r=taskgraph-reviewers,aki
https://hg.mozilla.org/integration/autoland/rev/9d637eea1fad
Make docker image_paths extendable by projects. r=taskgraph-reviewers,aki
https://hg.mozilla.org/integration/autoland/rev/8f7af43a4581
Move tb-debian-mingw docker-image definition to Thunderbird repo. r=taskgraph-reviewers,aki

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/38b2b48db658
https://hg.mozilla.org/mozilla-central/rev/9d637eea1fad
https://hg.mozilla.org/mozilla-central/rev/8f7af43a4581

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8ebc9f581e89
Allow for Docker images to be defined in comm/taskcluster/docker. r=mkmelin
https://hg.mozilla.org/comm-central/rev/06424ba4ea53
Move tb-debian-mingw docker-image definition to comm repo. r=mkmelin