Closed Bug 1665421 Opened 4 years ago Closed 3 years ago

Welcome to TB Daily account hub won't let me add email account: Uncaught Exception (accountUtils.js:237), lots of console errors (with existing installations of same release channel in other folders)

Categories

(Thunderbird :: Account Manager, defect, P2)

Unspecified
Windows

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: thomas8, Unassigned)

References

Details

Attachments

(4 files)

[EDIT 2021-03-03]

With the benefit of hindsight, this bug probably requires having an existing installation of the same release channel, but in another folder. I understand that this is the precondition for getting the "Important News - ...new profile" alert seen in attachment 9182449 [details].

STR

1.) install 1st instance of Thunderbird in a new folder (C:\test\install1) of a virgin OS profile, create email account, close.
2.) install 2nd instance of Thunderbird (same release channel as in step 1) in another new folder (C:\test\install2).

  • close "Important news: This installation of ... has a new profile" via (x) button
  • switch to 3-pane tab
  • open Error console (Ctrl+Shift+J)
  • from "Welcome to Thunderbird" account hub, click [Email] button to add a new account.

Actual result

  • Important caveat: You'll only get the errors for the first startup of the second install. For subsequent startups, it's all fine and good.
  • distorted alert: "Important News - ...new profile" (oversize alert is bug 1695719): "This installation of {Thunderbird/Daily/...} has a new profile..." (make sure you are seeing this, I believe without this you will not see the bug). close the alert on (x), don't do anything else.
  • After clicking on [Email] button from "Welcome..." hub, NOTHING.
  • Loads of errors in console (see screenshots attached to this bug), the last one from the [Email] button being:
Uncaught
Exception { name: "NS_ERROR_FAILURE", message: "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMailSession.topmostMsgWindow]", result: 2147500037, filename: "chrome://messenger/content/accountUtils.js", lineNumber: 235, columnNumber: 0, data: null, stack: "AddMailAccount@chrome://messenger/content/accountUtils.js:235:3\nonclick@chrome://messenger/content/msgAccountCentral.xhtml:1:1\n", location: XPCWrappedNative_NoHelper }
accountUtils.js:235

Expected:

  • installing in another folder should not be affected by previous installations of the same channel in other folders
  • Trying to create an existing email account via Welcome hub's [Email] button should succeed without console errors

(Original description)

Trying to add existing email account on first time account hub fails with uncaught exception.

Using a try build of current daily (from Bug 1665321 Comment 3):
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=068128352d3c6f40ce908cdcdf28c53c433cce1f
82.0a1 (2020-09-16) (64-bit)

Uncaught
Exception { name: "NS_ERROR_FAILURE", message: "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMailSession.topmostMsgWindow]", result: 2147500037, filename: "chrome://messenger/content/accountUtils.js", lineNumber: 237, columnNumber: 0, data: null, stack: "AddMailAccount@chrome://messenger/content/accountUtils.js:237:3\nonclick@chrome://messenger/content/msgAccountCentral.xhtml:1:1\n", location: XPCWrappedNative_NoHelper }
accountUtils.js:237
AddMailAccount chrome://messenger/content/accountUtils.js:237
onclick chrome://messenger/content/msgAccountCentral.xhtml:1

Also, shouldn't the empty folder pane be hidden for this scenario?

And loads of other error messages in the error console before that. :-/

Why would we remove folder pane?
Anyway, error messages are not good, but I maybe not sev=1? But if it's super important to 78 it SHOULD be P1.

(In reply to Wayne Mery (:wsmwk) from comment #4)

Why would we remove folder pane?

Hide, not remove. What do you do with an empty folder pane before accounts are set up?

Anyway, error messages are not good, but I maybe not sev=1?

It's not about the error message, it's about being unable to set up an account when Daily first starts up. That's pretty bad for out of the box UX.

But if it's super important to 78 it SHOULD be P1.

Note: I have only reported this against Daily, not tested for TB78 first install. Have you?

Severity: S1 → S2

sorry for the error - I don't know if this happens in 78. But I don't see in with beta 81.

I agree about the folder pane - I forgot we don't show it when there are no accounts

I don't see it with today's build 20200917095518 on Ubuntu.

Created a test profile.
Started Daily.
Dismissed the account creation wizard.
Clicked every option and got the correct dialog window for each.
Clicked the Email option and created an account.

Creating email accounts is the second thing I do, after enabling the Menu bar when testing candidates.

WFM? Thomas, can you confirm?

STR: (In reply to Magnus Melin [:mkmelin] from comment #8)

WFM? Thomas, can you confirm?

Still fails for me exactly as described on latest Daily 83.0a1 (2020-10-19) (64-bit), Win10.
N.B. Pls use ni?thomas8.

My steps and my OS are different from Walt's in comment 7, I'm on windows and not using a test profile, neither OS test profile, nor TB test profile. This time I have downloaded the .zip, unpacked to C:\test, and started thunderbird.exe.
I think with "new profile per installation", existing profiles/setups shouldn't have any influence when I install TB into new folder.

STR: (on Win10)

  1. download https://ftp.mozilla.org/pub/thunderbird/nightly/latest-comm-central/thunderbird-83.0a1.en-US.win64.zip
  2. unpack into C:\test\
  3. Start C:\test\thunderbird\thunderbird.exe
    --> takes ages to react and do anything
    --> alert "Important News: This installation of Daily has a new profile..." (confirm that) on top of 3-pane (decribed below)
  4. Click [Continue] on "Important News" alert
    --> tabs are auto-loaded: "Thunderbird privacy notice" & "Important News: Changes to your Daily profile"
  5. select home tab
  6. click on "Choose what to setup: Email" button from welcome-account central

Actual result:

  • folder pane shown next to first-time account central (should be hidden)
  • Email-setup button does nothing
  • loads of errors in console, including those mentioned above for the email button.

Expected:

  • Email Account Setup Wizard

Here's a screenshot log of partial STR and what happens after clicking thunderbird.exe, including all the errors in console.

Attachment #9182449 - Attachment description: 1665421_dailyEmailSetupFail_actualResult.webp → Screenshot 2: STR and actual results including console errors after starting virgin thunderbird.exe on Win10 (as extracted from zip install file)

The last two error messages are:

Uncaught TypeError: can't access property "value", gStatusBar is null
    _setActiveThinkingState chrome://messenger/content/tabmail.js:1807
    updateCurrentTab chrome://messenger/content/tabmail.js:1680
    connectedCallback chrome://messenger/content/tabmail-tabs.js:660
    set selectedIndex chrome://messenger/content/tabmail-tabs.js:723
    set selectedItem chrome://global/content/elements/tabbox.js:565
    _selectNewTab chrome://global/content/elements/tabbox.js:735
    on_mousedown chrome://global/content/elements/tabbox.js:331
    handleEvent chrome://global/content/customElements.js:466
tabmail.js:1807:9
Uncaught Exception
​columnNumber: 0
​data: null
​filename: "chrome://messenger/content/accountUtils.js"
​lineNumber: 237
​location: XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), filename: Getter, name: Getter, … }
​message: "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMailSession.topmostMsgWindow]"
​name: "NS_ERROR_FAILURE"
​result: 2147500037
​stack: "AddMailAccount@chrome://messenger/content/accountUtils.js:237:3\nonclick@chrome://messenger/content/msgAccountCentral.xhtml:1:1\n"
​<prototype>: ExceptionPrototype { toString: toString(), name: Getter, message: Getter, … }
accountUtils.js:237
    AddMailAccount chrome://messenger/content/accountUtils.js:237
    onclick chrome://messenger/content/msgAccountCentral.xhtml:1

As requested by Magnus, I have just retested this...

  • with the .exe installer flavor of Daily 84.0a1 (2020-10-25) (64-bit) [1]
  • installing into a new folder which creates a new profile (so the fact that there's dozens of other TB installations on this Windows account shouldn't matter because we're starting from scratch, right? This was working before).

...and the results are just the same:

  • more than 2 minutes of waiting time until the UI suddenly appears
  • LOADS of console errors including several uncaught exceptions
  • empty folder pane shown
  • Email setup button does nothing.

I think we should take this bug more serious?

[1] https://ftp.mozilla.org/pub/thunderbird/nightly/latest-comm-central/thunderbird-84.0a1.en-US.win64.installer.exe

Flags: needinfo?(mkmelin+mozilla)
OS: Unspecified → Windows
Summary: Welcome to TB Daily account hub won't let me add email account: Uncaught Exception (accountUtils.js:237) → Welcome to TB Daily account hub won't let me add email account: Uncaught Exception (accountUtils.js:237), lots of console errors

Console Errors seen just after first startup and having clicked on nothing but "Continue" and "Email" setup button

(In reply to Thomas D. (:thomas8) from comment #9)

STR: (on Win10)

(In reply to WaltS48 [:walts48] from comment #7)

I don't see it with today's build 20200917095518 on Ubuntu.

Created a test profile.

  • Is that an OS profile or a TB profile which you created?
  • Are you able to test on Windows 10?
  • If yes, could you retest this with my STR from comment 9 (pls use win64.exe installer of latest daily, and mention the installation file download URL)?
Flags: needinfo?(wls220spring)
The content of attachment 9183727 [details] has been deleted for the following reason:

Deleted at request of author

(In reply to Thomas D. (:thomas8) from comment #15)

(In reply to Thomas D. (:thomas8) from comment #9)

STR: (on Win10)

(In reply to WaltS48 [:walts48] from comment #7)

I don't see it with today's build 20200917095518 on Ubuntu.

Created a test profile.

  • Is that an OS profile or a TB profile which you created?

I used my tester OS profile and created a new TB profile.

  • Are you able to test on Windows 10?

Yes

  • If yes, could you retest this with my STR from comment 9 (pls use win64.exe installer of latest daily, and mention the installation file download URL)?

Downloaded https://archive.mozilla.org/pub/thunderbird/nightly/latest-comm-central/thunderbird-84.0a1.en-US.win64.installer.exe

Installed to C:\Program Files\Thunderbird Daily in my primary Windows 10 account and added the icon to the desktop. It is the default location.

Clicked the desktop icon and the Profile Manager opened, created a profile and clicked Start.

Dismissed the Account Setup and Integration dialogs.

Not seeing a folder pane, clicked every account button in the Account Hub, and got the correct dialog window for each.

I did not see the alert, "Important News: This installation of Daily has a new profile..." (confirm that) on top of 3-pane.

Flags: needinfo?(wls220spring)

(In reply to WaltS48 [:walts48] from comment #18)

I used my tester OS profile and created a new TB profile.

Thunderbird is supposed to create the TB profile for you in a regular setup.
One difference between your test and mine is that I'm not using a dedicated OS profile, so my registry might have remains from other TB setups. Does anyone know how installing several instances of the same release channel into different folders behaves wrt registry? My understanding is that the instances should be totally independent, separate profile, separate registry handling?

Installed to C:\Program Files\Thunderbird Daily in my primary Windows 10 account and added the icon to the desktop.

You added the icon to the desktop? Or Thunderbird did?

It is the default location.
Clicked the desktop icon and the Profile Manager opened, created a profile and clicked Start.

Weird - why would you get the profile manager?
Can you file a screenshot of profile manager with private data removed?

Dismissed the Account Setup and Integration dialogs.

That's definitely different from my steps as illustrated by my screenshots above.

Not seeing a folder pane, clicked every account button in the Account Hub, and got the correct dialog window for each.
I did not see the alert, "Important News: This installation of Daily has a new profile..." (confirm that) on top of 3-pane.

Exactly. We are not seeing the same thing, so we are not testing the same thing.

Fwiw, I'm also seeing this bug on yesterday's beta 83.0b1 (32-Bit), DE, on Win10, installing into a new folder outside the official programs folder, with pre-existing installs of the same release channel.

(In reply to Thomas D. (:thomas8) from comment #19)

(In reply to WaltS48 [:walts48] from comment #18)

I used my tester OS profile and created a new TB profile.

Thunderbird is supposed to create the TB profile for you in a regular setup.
One difference between your test and mine is that I'm not using a dedicated OS profile, so my registry might have remains from other TB setups. Does anyone know how installing several instances of the same release channel into different folders behaves wrt registry? My understanding is that the instances should be totally independent, separate profile, separate registry handling?

Installed to C:\Program Files\Thunderbird Daily in my primary Windows 10 account and added the icon to the desktop.

You added the icon to the desktop? Or Thunderbird did?

Thunderbird did because I checked the "On my Desktop" option in the installation process.

It is the default location.
Clicked the desktop icon and the Profile Manager opened, created a profile and clicked Start.

Weird - why would you get the profile manager?

May be because I don't have " Always use the selected profile without asking at startup" enabled.
Just enabled that and TB 78.4.0 opens without asking from the desktop icon, but not when using the pinned to taskbar icon.

Can you file a screenshot of profile manager with private data removed?

Let me try again with the Daily and install it into a new Test folder using a custom install.
That should be C:\test\ and not C:\WaltS48\test?

Do I allow the app to make changes to my device or not?

Dismissed the Account Setup and Integration dialogs.

That's definitely different from my steps as illustrated by my screenshots above.

Not seeing a folder pane, clicked every account button in the Account Hub, and got the correct dialog window for each.
I did not see the alert, "Important News: This installation of Daily has a new profile..." (confirm that) on top of 3-pane.

Exactly. We are not seeing the same thing, so we are not testing the same thing.

I guess I'm testing the way a user would install it, which is pretty close to the way I install the release, beta and daily.

When testing release candidates on Win 10 I do a custom install into the Downloads folder of my test user account. Haven't seen you problem there with a release or beta candidate.

Flags: needinfo?(bugzilla2007)

(In reply to WaltS48 [:walts48] from comment #21)

Weird - why would you get the profile manager?

May be because I don't have " Always use the selected profile without asking at startup" enabled.
Just enabled that and TB 78.4.0 opens without asking from the desktop icon, but not when using the pinned to taskbar icon.

Can you file a screenshot of profile manager with private data removed?

Let me try again with the Daily and install it into a new Test folder using a custom install.
That should be C:\test\ and not C:\WaltS48\test?

Don't think that makes any difference.

Do I allow the app to make changes to my device or not?

Sure, why not.

Dismissed the Account Setup and Integration dialogs.

Exactly. We are not seeing the same thing, so we are not testing the same thing.

I guess I'm testing the way a user would install it, which is pretty close to the way I install the release, beta and daily.

When testing release candidates on Win 10 I do a custom install into the Downloads folder of my test user account. Haven't seen you problem there with a release or beta candidate.

I'm still puzzled how Walt is getting the profile manager on a fresh install, but I'm now inclined to think this:

  • This bug probably requires existing profiles (maybe of same channel) to occur, so that you'll get the "Important news ... new profile" alert - assuming that you'll only get the alert when there are existing profiles - can someone confirm if that is so?
  • I do have "Always use the selected profile without asking at startup" enabled - guess that applies to all installs, right? However, when installing into a custom folder which by definition creates a new profile to be used, why would that play a role?
  • Walt, are you saying that you are not getting the new profile alert when installing to a custom folder which didn't have a previous installation?
  • I'd say that regardless of which existing installs I have, or how they are configured, installing into a new folder with a new profile should just work, according to the one-profile-per-install philosophy.
Flags: needinfo?(bugzilla2007)

Downloaded 84.0a1

20201107083145
https://hg.mozilla.org/comm-central/rev/df9a40274fe58403700e90a026d243718512249a
https://hg.mozilla.org/mozilla-central/rev/e40cc6272439b7fa848bdf875bb41d7f4b1a3b71

Installed to its default location allowing the app to make changes to my device.
Double clicked the desktop icon created during the installation.
The profile manager opened.
Clicked the "Create Profile" button and completed the process.
Clicked the "Start Daily" button.
Dismissed the account creation wizard.
Skipped system integration.
Clicked the "Email" button in the account hub.
Created my primary email account with no problem.

Quit Daily.
Restarted Daily, deleted all profiles and data from the profile manager.
Uninstalled 78.4.1 and 84.0a1.
Deleted profiles.ini and installs.ini
Reinstalled Daily
Started Daily and it opened with the main and account setup window. (No profile manager).
Dismissed the account setup window.
Skipped system integration again.
Clicked the "Email" button in the account hub.
Created my primary email account with no problem.

Default location or custom location doesn't make a difference.

I think the "Important news...New Profile" alert is the first run message I've heard about, but have never seen.

Tried it on a fresh windows install. I didn't have any problems (or at least not this problem).

Flags: needinfo?(mkmelin+mozilla)

Still happening in virtually exactly the same way when installing TB 78.7.1 (64-bit) into its own folder, and TB says it created a new profile, and failing to add an existing email account, with same errors shown above, and the empty folder pane shown in spite of no account present.

(In reply to Thomas D. (:thomas8) from comment #25)

Still happening in virtually exactly the same way when installing TB 78.7.1 (64-bit) into its own folder, and TB says it created a new profile, and failing to add an existing email account, with same errors shown above, and the empty folder pane shown in spite of no account present.

It failed on first start. Interestingly, on second start without changing anything, it's now succeeding and auto-showing the "Set up your existing email address" dialog.

I hate this fail. Hit it again on 87.0b2 (64-Bit) DE (from .exe), downloaded from https://archive.mozilla.org/pub/thunderbird/candidates/87.0b2-candidates/build1/

I think it's important to understand that I'm installing in a new, blank folder, BUT on a Win10 account which already has other betas in other folders. So I'm getting the new profile dialog (which is correct), but thereafter I'm seeing blank folder pane, and clicking the E-mail button from the Welcome account hub fails to do anything with many errors in console (as seen in screenshot).

The last error on the Email button is this one (same as reported before in this bug):

Uncaught
Exception { name: "NS_ERROR_FAILURE", message: "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMailSession.topmostMsgWindow]", result: 2147500037, filename: "chrome://messenger/content/accountUtils.js", lineNumber: 235, columnNumber: 0, data: null, stack: "AddMailAccount@chrome://messenger/content/accountUtils.js:235:3\nonclick@chrome://messenger/content/msgAccountCentral.xhtml:1:1\n", location: XPCWrappedNative_NoHelper }
accountUtils.js:235

Summary: Welcome to TB Daily account hub won't let me add email account: Uncaught Exception (accountUtils.js:237), lots of console errors → Welcome to TB Daily account hub won't let me add email account: Uncaught Exception (accountUtils.js:237), lots of console errors (with existing installations of same release channel in other folders)

Updated comment 0 so that we have proper description with STR, Actual result, Expected Result.

Inviting everyone to retest. I believe reproducing this bug requires TWO installations of Thunderbird in the same release channel, but different folder. Also, only occurs once with first startup of second install, subsequent startups are fine.

(Next time when I skip proper STR, can someone please complain?)

Rob, did you just say on Matrix that you were able to reproduce this bug?

Pls confirm bc so far, no one was able to do that... (guess my steps weren't good enough before I updated them today...)

Flags: needinfo?(rob)

I don't know what's going on, but you should re-test after bug 1689724.

Thomas, see this with 88?

Flags: needinfo?(bugzilla2007)

(In reply to Magnus Melin [:mkmelin] from comment #31)

Thomas, see this with 88?

I've retested comment 0 on 88.0a1 (2021-03-17) (64-Bit), according to the very letter (which is quite a hassle...):

  • new Windows account
  • 2 subsequent installs with account creation, same channel, different folders

This bug did no longer occur, no folder pane before account creation, account creation occured automatically and worked correctly for both subsequent installations. Couple of errors in console, one account-creation related, but different from above (see my next comment).

However, I did not even get the "Important news: This installation of ... has a new profile" alert for the second installation, which looks like a bug.
I suspect that if the "...has new profile" alert would correctly occur, this bug might re-occur, too.

What are the exact conditions for the "Important news: This installation of ... has a new profile" alert to occur?

Flags: needinfo?(bugzilla2007)

88.0a1 (2021-03-17) (64-Bit), 2 subsequent installs, same channel, different folders.

1st and 2nd install

[Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 692" data: no] L10nRegistry.jsm:692:19
loadSync resource://gre/modules/L10nRegistry.jsm:692
fetchFile resource://gre/modules/L10nRegistry.jsm:607
generateResourceSetSync resource://gre/modules/L10nRegistry.jsm:512
map self-hosted:221
generateResourceSetSync resource://gre/modules/L10nRegistry.jsm:507
generateResourceSetsForLocaleSync resource://gre/modules/L10nRegistry.jsm:449
InterpretGeneratorResume self-hosted:1480
next self-hosted:1428
generateBundlesSync resource://gre/modules/L10nRegistry.jsm:186
InterpretGeneratorResume self-hosted:1480
next self-hosted:1428
touchNext resource://gre/modules/Localization.jsm:167
generateBundles resource://gre/modules/Localization.jsm:473
<anonym> resource:///modules/OTRUI.jsm:16
get resource://gre/modules/XPCOMUtils.jsm:58
_str resource:///modules/OTRUI.jsm:20
initStrings resource:///modules/OTRUI.jsm:38
init resource:///modules/OTRUI.jsm:259
InterpretGeneratorResume self-hosted:1480
AsyncFunctionNext self-hosted:690

Region.jsm: Error fetching region Error: TIMEOUT
_timeout resource://gre/modules/Region.jsm:772
Region.jsm:417:11
_getRegion resource://gre/modules/Region.jsm:417

Region.jsm: Failed to fetch region Error: TIMEOUT
_getRegion resource://gre/modules/Region.jsm:419
Region.jsm:216:11
_fetchRegion resource://gre/modules/Region.jsm:216

[Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIMsgAccountManager.loadVirtualFolders]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: chrome://messenger/content/msgMail3PaneWindow.js :: LoadPostAccountWizard :: line 859" data: no] msgMail3PaneWindow.js:859:20
LoadPostAccountWizard chrome://messenger/content/msgMail3PaneWindow.js:859
onWizardShutdown chrome://messenger/content/accountcreation/emailWizard.js:1986
onunload chrome://messenger/content/accountcreation/emailWizard.xhtml:1

2nd install

This alert was not seen in spite of pre-existing profile on same channel:
"Important news: This installation of ... has a new profile"
Errors same as above.

I might have hit this once, but wasn't sure. In the meantime other account setup bugs have been fixed like no folder pane after a manual setup that make me wonder whether it was this bug or something else.

Flags: needinfo?(rob)

Please try this again now with 91 - a lot changed in this area.

Flags: needinfo?(bugzilla2007)
See Also: → 1723973

(In reply to Magnus Melin [:mkmelin] from comment #35)

Please try this again now with 91 - a lot changed in this area.

Looks like a lot has improved in this area :-))

  • Retested on 91.0b6 (32-bit), Win10.
  • Existing beta6 and other installations.
  • Installed another instance of 91.0b6 in a different folder.

Actual result:

  • The main problem of this bug and the associated error messages are gone: Ignoring/closing the Account Setup tab and then using the Email button of Account Central on a virgin (2nd instance) profile no longer fails to switch to or re-open Account Setup tab. So we can close this WFM.
  • I am no longer seeing the "Important News - ...new profile" alert (see bug 1695719): "This installation of {Thunderbird/Daily/...} has a new profile...". Can someone confirm that this alert has been removed (rather than just reworded)?
  • However, I'm still seeing a couple of error messages before even doing anything (incl. Can't find profile directory) - filed as bug 1723981.
  • Nit: Something wrong when you decide to close the Account Setup tab for the first time on a virgin install - filed as bug 1723973.
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(bugzilla2007)
Resolution: --- → WORKSFORME
See Also: → 1723981

The "Important News - ...new profile" dialog has indeed recently been removed.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: