1665527 - Not able to control another muted media after pressing `next/prev track` on controllable muted media

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Alastor Wu [:alwu]]

STR.

1. go to https://www.youtube.com/watch?v=SaicC0AFwUc&list=PL4360C46560CE3B16
2. play video
3. mute video
4. press next track
5. jump to next video, and muted video started

Expect.
6. still able to control video via media keys

Actual.
6. Not able to control video via media keys

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1665527 - part1 : deactivate a controller only when it doesn't have controlled media and active media session.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1665527 - part3 : add a test.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1665527 - part4 : add new testcase for 'browser_stop_control_after_media_reaches_to_end.js'.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1665527 - part2 : notify media session status based on its document's activity state.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b97b8759b686
part1 : deactivate a controller only when it doesn't have controlled media and active media session. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a18103008464
part2 : notify media session status based on its document's activity state. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a683efbf01c1
part3 : add a test. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/216b96d6a2b3
part4 : add new testcase for 'browser_stop_control_after_media_reaches_to_end.js'. r=chunmin

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b97b8759b686
https://hg.mozilla.org/mozilla-central/rev/a18103008464
https://hg.mozilla.org/mozilla-central/rev/a683efbf01c1
https://hg.mozilla.org/mozilla-central/rev/216b96d6a2b3

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for wpt leakchecks on setactionhandler.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/49c98e03b5877b93000a6cc3ee7b1de9808e8e91
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316475233&repo=autoland&lineNumber=6481

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a035588b98d
part1 : deactivate a controller only when it doesn't have controlled media and active media session. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/3e345c20dc2e
part2 : notify media session status based on its document's activity state. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/b5107408e698
part3 : add a test. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/6975dde1cb29
part4 : add new testcase for 'browser_stop_control_after_media_reaches_to_end.js'. r=chunmin

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/49c98e03b587

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5a035588b98d
https://hg.mozilla.org/mozilla-central/rev/3e345c20dc2e
https://hg.mozilla.org/mozilla-central/rev/b5107408e698
https://hg.mozilla.org/mozilla-central/rev/6975dde1cb29

Comment 12

[Alastor Wu [:alwu]]

Comment on attachment 9176699 [details]
Bug 1665527 - part1 : deactivate a controller only when it doesn't have controlled media and active media session.

Beta/Release Uplift Approval Request

• User impact if declined: Users won't be able to control video via media keys after pressing prev/next track under certain condition
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please follow comment0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch extends the tab's ability of receiving media keys, it's a small change which only affect websites using MediaSession API. In addition, attaching new automation tests to increase test coverage helps to reduce the risk as well.
• String changes made/needed:

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9176699 [details]
Bug 1665527 - part1 : deactivate a controller only when it doesn't have controlled media and active media session.

Thanks for adding tests.

Approved for 82.0b4

Comment 14

[Rares Doghi, Desktop QA]

This issue is verified as Fixed in our latest Nightly build on Windows 10 , Mac OSX 10.15 and Ubuntu 18.04. I will update the Flag for 82 and 81 and I recheck this issue in Beta 82.0b4, I will leave the qe-verify + flag for now.

Comment 15

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/53ea7f7d20b0
https://hg.mozilla.org/releases/mozilla-beta/rev/908a3c001e29
https://hg.mozilla.org/releases/mozilla-beta/rev/25dad62aacd3
https://hg.mozilla.org/releases/mozilla-beta/rev/b653d3abcc60

Comment 16

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Beta 82.0b4 on Windows 10, Mac OSX 10.15 and Ubuntu 18.04.