1665532 - Image frame's intrinsic width should consider intrinsic aspect-ratio and its height

Status: RESOLVED DUPLICATE of bug 1672462

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: image-min-content-width.html

While working on bug 1316534, I notice my WIP patch fails http://wpt.live/css/css-flexbox/flex-minimum-width-flex-items-007.xht (All the other browsers fail it, too. See this result.)

The root cause is that when we calculating content size suggestion of a flex item image, we take the image's intrinsic size as the min-content width, and the width is currently not affected by the image's intrinsic aspect ratio and height. See the attached testcase for comparision.

https://github.com/w3c/csswg-drafts/issues/5032 has more discussion on this topic.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

It turns out that this bug can affect some real webpages. I have a fix in https://phabricator.services.mozilla.com/D94802 in bug 1672462, and deleted all mention of this bug number, so I'll make this a dup.

We should fix intrinsic width by considering the image's intrinsic aspect ratio and height in either bug 1646100 or bug 1670151.

Comment 2

[Philip Jägenstedt [:foolip]]

There's a bunch of discussion in https://github.com/web-platform-tests/wpt/pull/26250 (linking to this bug) that might be helpful in understanding the cross-browser results of [css-flexbox] delete flex.

Comment 3

[Philip Jägenstedt [:foolip]]

Oops, I copied the wrong half the PR title, I mean results of flex-minimum-width-flex-items-007.xht.