1646100 - Take intrinsic size into account when using aspect-ratio

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Boris Chiou [:boris]]

This should address this issue: https://github.com/w3c/csswg-drafts/issues/5032.

There are some examples when the ratio-determining axis uses intrinsic sizes, e.g. max-content, min-content.

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1646100 - Take LogicalSize type for containing block and boxing size adjustment for ComputeISizeValue.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1646100 - Compute {min|max|fit}-content from the definite block-size and aspect-ratio.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1646100 - min-width:auto together with apect-ratio should take the intrinsic content size into account when width is {min|max|fit}-content or auto.

Comment 4

[Boris Chiou [:boris]]

I think https://bugzilla.mozilla.org/show_bug.cgi?id=1670151 is also fixed by the 2nd patch. However, I will add the test in that bug.

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1646100 - Add UseBoxSizing for AspectRatio class.

In some cases, the aspect ratio works with box sizing dimensions, and
sometimes it works only with content box dimensions. We need an extra
flag to know this, and handle it well while computing the size in
ratio-dependent axis.

Comment 6

[Phabricator Automation]

Comment on attachment 9193855 [details]
Bug 1646100 - Add UseBoxSizing for AspectRatio class.

Revision D100072 was moved to bug 1683424. Setting attachment 9193855 [details] to obsolete.

Comment 7

[Boris Chiou [:boris]]

Attachment: Bug 1646100 - Rewrite the computation for min/max inline size for table cols and table cells.

We need a simplified version for ComputeISizeValue() for table cols and
table cells to avoid taking aspect-ratio into account for the following
patches.

Comment 8

[Phabricator Automation]

Comment on attachment 9195352 [details]
Bug 1646100 - Rewrite the computation for min/max inline size for table cols and table cells.

Revision D100749 was moved to bug 1685207. Setting attachment 9195352 [details] to obsolete.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0825deaefb7e
Take LogicalSize type for containing block and boxing size adjustment for ComputeISizeValue. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/47d9283b4c33
Compute {min|max|fit}-content from the definite block-size and aspect-ratio. r=TYLin,emilio
https://hg.mozilla.org/integration/autoland/rev/12053c7dc8e4
min-width:auto together with apect-ratio should take the intrinsic content size into account when width is {min|max|fit}-content or auto. r=TYLin

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27248 for changes under testing/web-platform/tests

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0825deaefb7e
https://hg.mozilla.org/mozilla-central/rev/47d9283b4c33
https://hg.mozilla.org/mozilla-central/rev/12053c7dc8e4

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot