Open Bug 1665559 Opened 4 years ago Updated 4 years ago

The VP8 Hardware encoder for webrtc gets ignored

Categories

(Core :: WebRTC: Audio/Video, defect, P3)

65 Branch
Unspecified
Android
defect

Tracking

()

People

(Reporter: pehrsons, Unassigned)

References

(Regression)

Details

(Keywords: regression)

See https://hg.mozilla.org/mozilla-central/rev/7e0b405f7a1d98313f051d77424c321f9caeeaa8#l2.120 where the code to initialize the hardware encoder was moved, and the fallback mechanism made to be permanent.

That behavior is still around today.

Hmm, I don't think we build with MOZ_WEBRTC_MEDIACODEC anywhere, because compilation errors would occur.

Looks like it was set up to get defined here.

But we dropped that define in bug 1382182, in particular here.

We'll have to figure out whether this path is something we want to keep. John, as the Android media expert what are your thoughts?

Flags: needinfo?(jolin)
Regressed by: 1382182
Has Regression Range: --- → yes

This was implemented after the Android remote codec (bug 1257777) was introduced. Now that we have the platform encoder module (bug 1425277), it can be replaced by that.

The current Android implementation (bug 1570337) doesn't support VPx yet. I'll file a bug for that and link it with this one.

Flags: needinfo?(jolin)
Depends on: 1665776

Thanks! Let's wait for bug 1665776 before taking action here.

Assignee: apehrson → nobody
Status: ASSIGNED → NEW
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.