1665638 - remove layout.css.clip-path-path.enabled

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

We've shipped it for a year now (Bug 1488530).

Comment 1

[Seun]

I am in, can it be assigned to me?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Sure!

Comment 3

[Emilio Cobos Álvarez (:emilio)]

So in order to fix this:

• You need to remove this chunk of code that defines the pref
• You need to remove the rust code that checks for the pref, so remove is_clip_path_path_enabled and the code checking it.
• Tweak the three places that check the prefs for tests. The first one should be removed, the others, the if can be removed and the code inside it can be moved up.

Comment 4

[Seun]

i think i am done,how do i push so we can test or how do i test

Comment 5

[Seun]

Attachment: Bug 1665638 - Removed the redundancy text from the basic_shape.rs and staticPrefList.yaml and also removed the condition from the property_database.js. #style

Comment 6

[Seun]

Attachment: Bug 1665638 2nd Revision of earlier submitted patch for this bug

Depends on D90801

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 8

[Sonia Singla :soniasingla]

I am working over this bug, will attach the patch soon :)

Comment 9

[Sonia Singla :soniasingla]

Attachment: Bug 1665638 - Remove layout.css.clip-path-path.enabled.r?emilio

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/139034dc7d65
Remove layout.css.clip-path-path.enabled.r=emilio

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/139034dc7d65