1665739 - Perma toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js | Test timed out - when Gecko 82 merges to Beta on 2020-09-21

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Please be aware this would turn into a production failure for beta next Monday.

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=Plc30SJcSIut9ZWRG23aXA.0&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=314b5bf834e4bd95b88642c4397504af8c18ac2e&searchStr=browser-chrome

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=315958094&repo=try

[task 2020-09-17T14:54:39.034Z] 14:54:39 INFO - Observed addon-install-blocked for 1 installs
[task 2020-09-17T14:54:39.035Z] 14:54:39 INFO - Install of http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/recommended.xpi was in state 3
[task 2020-09-17T14:54:39.035Z] 14:54:39 INFO - Console message: 1600354032003 addons.repository DEBUG cacheAddons: enabled false IDs ["[e-mail]"]
[task 2020-09-17T14:54:39.035Z] 14:54:39 INFO - Buffered messages logged at 14:48:38
[task 2020-09-17T14:54:39.035Z] 14:54:39 INFO - Longer timeout required, waiting longer... Remaining timeouts: 3
[task 2020-09-17T14:54:39.035Z] 14:54:39 INFO - Buffered messages logged at 14:50:08
[task 2020-09-17T14:54:39.035Z] 14:54:39 INFO - Longer timeout required, waiting longer... Remaining timeouts: 2
[task 2020-09-17T14:54:39.035Z] 14:54:39 INFO - Buffered messages logged at 14:51:38
[task 2020-09-17T14:54:39.035Z] 14:54:39 INFO - Longer timeout required, waiting longer... Remaining timeouts: 1
[task 2020-09-17T14:54:39.035Z] 14:54:39 INFO - Buffered messages logged at 14:53:02
[task 2020-09-17T14:54:39.035Z] 14:54:39 INFO - Console message: [JavaScript Error: "Unknown Collection "main/nimbus-desktop-experiments"" {file: "resource://services-settings/RemoteSettingsClient.jsm" line: 160}]
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO - UnknownCollectionError@resource://services-settings/RemoteSettingsClient.jsm:160:5
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO - sync@resource://services-settings/RemoteSettingsClient.jsm:470:13
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO -
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO - Buffered messages finished
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js | Test timed out -
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js | No unexamined telemetry events after test is finished - [] deepEqual [{"method":"install","object":"unknown","value":"26","extra":{"step":"started","source":"test-host","method":"installTrigger"}},{"method":"install","object":"unknown","value":"26","extra":{"step":"download_started","source":"test-host","method":"installTrigger"}},{"method":"install","object":"extension","value":"26","extra":{"step":"download_completed","download_time":"203","source":"test-host","method":"installTrigger","addon_id":"[e-mail]"}},{"method":"install","object":"extension","value":"26","extra":{"step":"site_warning","source":"test-host","method":"installTrigger","addon_id":"[e-mail]"}}] - JS frame :: resource://testing-common/AddonTestUtils.jsm :: hookAMTelemetryEvents/< :: line 1969
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO - Stack trace:
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO - resource://testing-common/AddonTestUtils.jsm:hookAMTelemetryEvents/<:1969
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO - chrome://mochikit/content/browser-test.js:nextTest:555
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO - Console message: 1600354478623 addons.xpi DEBUG Cancelling download of http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/recommended.xpi
[task 2020-09-17T14:54:39.036Z] 14:54:39 INFO - Console message: 1600354478647 addons.xpi DEBUG removeTemporaryFile: http://example.com/browser/toolkit/mozapps/extensions/test/xpinstall/recommended.xpi removing temp file /tmp/tmp-2w5.xpi
[task 2020-09-17T14:54:39.037Z] 14:54:39 INFO - GECKO(7851) | MEMORY STAT | vsize 3088MB | residentFast 357MB | heapAllocated 100MB
[task 2020-09-17T14:54:39.037Z] 14:54:39 INFO - TEST-OK | toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js | took 450144ms

Comment 1

[Shane Caraveo (:mixedpuppy)]

This test can be disabled on beta for a short while. The problem is that I used a dev-root signed addon in the test and forgot that wouldn't work on beta. I'll get that changed, but may not have time before uplift.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Will disable it on beta after central has merged to it tomorrow.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

disabled on beta: https://hg.mozilla.org/releases/mozilla-beta/rev/8bf0631b104fa072b4a4e634100dce2019ecc2c3

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1665739 fix recommended addon signature

Comment 5

[Shane Caraveo (:mixedpuppy)]

The patch uses a regular amo signed extension for the test now. It should land on nightly, uplift, then revert the patch from comment 3.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5cd69a7a0f4
fix recommended addon signature r=rpl

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f5cd69a7a0f4

Comment 8

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9176969 [details]
Bug 1665739 fix recommended addon signature

Beta/Release Uplift Approval Request

• User impact if declined: Some addon install flow changes are not tested.

Revert the patch in comment 3 along with landing this patch.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: Test was perma-fail on beta
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It can be re-disabled.
• String changes made/needed:

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9176969 [details]
Bug 1665739 fix recommended addon signature

test-only change, I'll get this into beta.

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b2abc17fccef8cf7d848bd362ac0a5a3d526a384
https://hg.mozilla.org/releases/mozilla-beta/rev/d5c9f8a62ed2563f7068e9289094f9150f3dc0a3

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Needinfo for open issue, test had been disabled.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Nevermind.