Closed Bug 1665757 Opened 1 year ago Closed 1 year ago

"Send attribution request" telemetry and ping do not work after the first restart for timestamp topsites

Categories

(Firefox :: Top Sites, defect, P1)

Firefox 81
Desktop
Unspecified
defect
Points:
1

Tracking

()

RESOLVED FIXED
82 Branch
Iteration:
82.2 - Sep 7 - Sep 20
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- unaffected
firefox81 - wontfix
firefox82 + verified

People

(Reporter: aflorinescu, Assigned: dao)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

[Tracking Requested - why for this release]:
Impacts the expected telemetry and attribution pings for admarket type link.

[Sugested Severity:]
S1/S2

[Environment:]

Windows 10
81RC2
82.0a1 most likely affected, but it's complicated to notice it without the fix from bug 1664516.

[Steps:]
  1. From Remote Settings administration, add a timestamp topsite https://www.example.com/#%YYYYMMDDHH%.
  2. From the Remote Settings configuration, set the above topsite to "Send attribution request to Mozilla server"
  3. Publish the changes and set Firefox to connect to the respective collection.
  4. Set a Firefox profile to connect to the configuration while switching the browser.topsites.useRemoteSetting to true.
  5. Start-up Firefox with the above profile configuration.
  6. Open a new tab and select from the address bar the topsite previously created.
  7. Open a new tab and select the previously selected topsite from the Topsites section in the about:newtab page.
  8. Restart the browser.
  9. Open a new tab and select from the address bar the topsite previously created.
  10. Open a new tab and select the previously selected topsite from the Topsites section in the about:newtab page.
[Actual Result:]

6,7: In browser console, enabling XHR, a ping to https://topsites.mozilla.io/cid/amzn_2020_a1 (2x)
6,7: Opening about:telemetry#events-tab in a new tab will show:
Two events for each topsite access:
click
attribution

After restart, the steps 9 and 10 do not log any ping or telemetry

[Expected Result:]

6,7,9,10. : In browser console, enabling XHR, a ping to https://topsites.mozilla.io/cid/amzn_2020_a1 (4x)
6,7,9,10.: Opening about:telemetry#events-tab in a new tab will show two events (click, attribution) for each topsite access.

[Note:]
  1. For debugging purposes, now staging main-preview has for DE region 4 timestamp links, the amazon link being future prod-like link
Summary: "Send attribution request" telemetry and ping do not work after the first restart"Send attribution request" telemetry and ping do not work after the first restart for timestamp topsites → Send attribution request" telemetry and ping do not work after the first restart for timestamp topsites
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Severity: -- → S2
Priority: -- → P1
Summary: Send attribution request" telemetry and ping do not work after the first restart for timestamp topsites → "Send attribution request" telemetry and ping do not work after the first restart for timestamp topsites
Iteration: --- → 82.2 - Sep 7 - Sep 20
Points: --- → 1
Attachment #9176472 - Attachment description: Bug 1665757 - Fix typo. r=mikedeboer,mak → Bug 1665757 - Correctly carry over a default top site's original URL to its derived frecency top site. r=mikedeboer,mak
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b9afe1b4543
Correctly carry over a default top site's original URL to its derived frecency top site. r=mikedeboer
See Also: → 1665909

This looks good on the Nightly 82 try-build.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

(In reply to Adrian Florinescu [:aflorinescu] from comment #4)

This looks good on the Nightly 82 try-build.

Further tests on RC2+fix respin looked good until I hit bug 1665971.

With bug bug 1665971 being invalid, reverified this with 82.0a1 2020-09-20 on Ubuntu 20.04, Windows 10 and Mac 10.13.6.

Per bkal, this isn't feature isn't targeting 81 anymore.

You need to log in before you can comment on or make changes to this bug.