1665757 - "Send attribution request" telemetry and ping do not work after the first restart for timestamp topsites

Status: RESOLVED FIXED

(Firefox :: Top Sites, defect, P1)

Description

[Adrian Florinescu [:aflorinescu]]

[Tracking Requested - why for this release]:
Impacts the expected telemetry and attribution pings for admarket type link.

[Sugested Severity:]
S1/S2

[Environment:]

Windows 10
81RC2
82.0a1 most likely affected, but it's complicated to notice it without the fix from bug 1664516.

[Steps:]

1. From Remote Settings administration, add a timestamp topsite https://www.example.com/#%YYYYMMDDHH%.
2. From the Remote Settings configuration, set the above topsite to "Send attribution request to Mozilla server"
3. Publish the changes and set Firefox to connect to the respective collection.
4. Set a Firefox profile to connect to the configuration while switching the browser.topsites.useRemoteSetting to true.
5. Start-up Firefox with the above profile configuration.
6. Open a new tab and select from the address bar the topsite previously created.
7. Open a new tab and select the previously selected topsite from the Topsites section in the about:newtab page.
8. Restart the browser.
9. Open a new tab and select from the address bar the topsite previously created.
10. Open a new tab and select the previously selected topsite from the Topsites section in the about:newtab page.

[Actual Result:]

6,7: In browser console, enabling XHR, a ping to https://topsites.mozilla.io/cid/amzn_2020_a1 (2x)
6,7: Opening about:telemetry#events-tab in a new tab will show:
Two events for each topsite access:
click
attribution

After restart, the steps 9 and 10 do not log any ping or telemetry

[Expected Result:]

6,7,9,10. : In browser console, enabling XHR, a ping to https://topsites.mozilla.io/cid/amzn_2020_a1 (4x)
6,7,9,10.: Opening about:telemetry#events-tab in a new tab will show two events (click, attribution) for each topsite access.

[Note:]

1. For debugging purposes, now staging main-preview has for DE region 4 timestamp links, the amazon link being future prod-like link

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1665757 - Correctly carry over a default top site's original URL to its derived frecency top site. r=mikedeboer,mak

Comment 2

[Dão Gottwald [:dao]]

mozilla-central try builds: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f146ca49a68591d68513b3d6169f1a208a9f7d2

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b9afe1b4543
Correctly carry over a default top site's original URL to its derived frecency top site. r=mikedeboer

Comment 4

[Adrian Florinescu [:aflorinescu]]

This looks good on the Nightly 82 try-build.

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4b9afe1b4543

Comment 6

[Adrian Florinescu [:aflorinescu]]

(In reply to Adrian Florinescu [:aflorinescu] from comment #4)

This looks good on the Nightly 82 try-build.

Further tests on RC2+fix respin looked good until I hit bug 1665971.

Comment 7

[Adrian Florinescu [:aflorinescu]]

With bug bug 1665971 being invalid, reverified this with 82.0a1 2020-09-20 on Ubuntu 20.04, Windows 10 and Mac 10.13.6.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Per bkal, this isn't feature isn't targeting 81 anymore.