1665815 - Black squares artifacts on Android WebRender (Emulator SwiftShader)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

When I enabled WebRender on Android Emulator, I saw black squares.

Comment 1

[Sotaro Ikeda [:sotaro]]

It looks similar to Bug 1558374. Clear seemed not work as expected.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Screenshot

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1665815 - Avoid using scissored glClear() on Android Emulator with SwiftShader

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04fd95dbbec4e28f940b4fc2ebe0ba835c9d10e0

Comment 5

[Jamie Nicol [:jnicol]]

What android emulator version are you running? And what Android version is the AVD? This appears to be with the swiftshader backend. does running the GPU backend work correctly?

Just so you know, I've actually just landed a patch to remove that code for Mali (bug 1663355). It wasn't the right fix, some websites still showed artefacts. So your patch will conflict with autoland.

Comment 6

[Jamie Nicol [:jnicol]]

Would you be able to run mozregression? If only Mali is buggy, or if only the emulator is buggy, then I assume it is just a driver/emulator bug. But if both are buggy, it makes me think that it could be a webrender bug.

Comment 7

[Sotaro Ikeda [:sotaro]]

By Bug 1485981, it seems that mozregression alway tries to install ARM on android. I tried locally on android x86 emulator, but it failed.

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #7)

By Bug 1485981, it seems that mozregression alway tries to install ARM on android. I tried locally on android x86 emulator, but it failed.

Sorry, it should be addressed by Bug 1651760.

Comment 9

[Sotaro Ikeda [:sotaro]]

(In reply to Jamie Nicol [:jnicol] from comment #5)

What android emulator version are you running? And what Android version is the AVD? This appears to be with the swiftshader backend. does running the GPU backend work correctly?

On Android 7.0, 8.0, 9.0 and 10.0. All used Swift Shader. When backend was GPU backend, the problem did not happen.

Comment 10

[Sotaro Ikeda [:sotaro]]

Bug 1663355 affected to the patch, I am going to update it.

Comment 11

[Sotaro Ikeda [:sotaro]]

Checked regression with the following.

./mach mozregression -n gve --good 2020-09-10 --bad 2020-05-01 --pref gfx.webrender.all:true --arch x86_64

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0fdeafcdcb41a6e7def0650ef1d93e3e5bef9299&tochange=6199f7b91e8bde7b7965585842d7a72e2e406e3e

Bug 1621390 seemed to cause the regression.

Comment 12

[Sotaro Ikeda [:sotaro]]

Confirmed that updated patch worked on Android Emulator with SwiftShader on Android 7, 8, 9 and 10.

Comment 13

[Jamie Nicol [:jnicol]]

(In reply to Sotaro Ikeda [:sotaro] from comment #11)

Checked regression with the following.

./mach mozregression -n gve --good 2020-09-10 --bad 2020-05-01 --pref gfx.webrender.all:true --arch x86_64

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0fdeafcdcb41a6e7def0650ef1d93e3e5bef9299&tochange=6199f7b91e8bde7b7965585842d7a72e2e406e3e

Bug 1621390 seemed to cause the regression.

Interesting. So the problem is perhaps to do with coloured scissored clears. So it seems different than the Mali bug, and it's not worth spending too much time on the emulator or swiftshader, so let's land this. Thanks!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b60c4c84feab
Avoid using scissored glClear() on Android Emulator with SwiftShader r=geckoview-reviewers,jnicol,agi

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b60c4c84feab