Closed Bug 1666133 Opened 1 year ago Closed 9 months ago

Missing vibrancy from macOS titlebar for built-in light theme (Mac)

Categories

(Thunderbird :: Theme, defect)

defect

Tracking

(thunderbird_esr78 wontfix, thunderbird86 wontfix)

RESOLVED FIXED
87 Branch
Tracking Status
thunderbird_esr78 --- wontfix
thunderbird86 --- wontfix

People

(Reporter: richrocksmyworld, Assigned: Paenglab)

References

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

Switch between default, light, and dark themes on OS X Catalina during the daytime (system theme is set to auto)

Actual results:

Light theme - light gray translucent tab bar
Dark theme - dark gray translucent tab bar
Default theme - solid mid-gray tab bar

Expected results:

Default theme - dark gray translucent tab bar

This would match the behaviour of Firefox on Mac where the default theme has a dark translucent tab bar. It would also be consistent with the picture of the theme in the preference pane.

Not clear to me how this should behave on Mac

Depends on: 1672081
Summary: Top tab bar not translucent with default theme (Mac) → Missing vibrancy from macOS titlebar for built-in light theme (Mac)
Severity: -- → S4
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch 1666133-vibrancy-titlebar.patch (obsolete) — Splinter Review

This gives the vibrancy back to the titlebar. Like bug 1672081 for FX.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9202649 - Flags: review?(alessandro)
Comment on attachment 9202649 [details] [diff] [review]
1666133-vibrancy-titlebar.patch

Review of attachment 9202649 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Maybe just update the commit message to include "macOS" so it's easier to understand or search when looking at the commit history.
Attachment #9202649 - Flags: review?(alessandro) → review+

Added the "macOS" to the commit message.

Attachment #9202649 - Attachment is obsolete: true
Attachment #9202651 - Flags: review+
Target Milestone: --- → 87 Branch

Is 78 affected?

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/df3a947cc2f1
Make the macOS titlebar use the vibrancy again. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.