1666133 - Missing vibrancy from macOS titlebar for built-in light theme (Mac)

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[tornado]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

Switch between default, light, and dark themes on OS X Catalina during the daytime (system theme is set to auto)

Actual results:

Light theme - light gray translucent tab bar
Dark theme - dark gray translucent tab bar
Default theme - solid mid-gray tab bar

Expected results:

Default theme - dark gray translucent tab bar

This would match the behaviour of Firefox on Mac where the default theme has a dark translucent tab bar. It would also be consistent with the picture of the theme in the preference pane.

Comment 1

[Wayne Mery (:wsmwk)]

Not clear to me how this should behave on Mac

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1666133-vibrancy-titlebar.patch

This gives the vibrancy back to the titlebar. Like bug 1672081 for FX.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9202649 [details] [diff] [review]
1666133-vibrancy-titlebar.patch

Review of attachment 9202649 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Maybe just update the commit message to include "macOS" so it's easier to understand or search when looking at the commit history.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1666133-vibrancy-titlebar.patch

Added the "macOS" to the commit message.

Comment 5

[Magnus Melin [:mkmelin]]

Is 78 affected?

Comment 6

[Richard Marti (:Paenglab)]

No.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/df3a947cc2f1
Make the macOS titlebar use the vibrancy again. r=aleca