1666198 - TestLegacyClick class in test_click.py does not disable "moz:webdriverClick"

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

As noticed while investigating some intermittent failures, the TestLegacyClick class doesn't turn off webdriver spec specific checks:

https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_click.py#79-85

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Marking as a fission bug given that my changes for bug 1493108 somehow increased the frequency of these failures, and we need to get it cleaned-up.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1666198 - [marionette] Stabilize element click unit tests.

First, by running all the tests in their own tab reduces the risk
of bad interactions between tests.

Also the legacy element click tests actually never tested the
legacy mode because "moz:webdriverClick" has been set to "true"
by default, but the capability for the tests hasn't been changed
to point to false.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a454690cfecc
[marionette] Stabilize element click unit tests. r=marionette-reviewers,maja_zf

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a454690cfecc