Commands in listener.js have to check if "current browsing context" is open (fails for removed frames)

NEW
Unassigned

Status

Product:
Testing
Component:
Marionette
Type:
enhancement
Importance:
P2
normal
Reported:
8 months ago
Modified:
8 months ago

People

(Reporter: whimboo, Unassigned)

Tracking

(Blocks 1 bug)

Version:
Version 3
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details
Reporter

Description

•
8 months ago 
We added the check for the "top-level browsing context" to each of the commands already a while ago, but we actually missed that we also have to check for each "browsing context".

Currently it fails when a frame is selected, and removed. All commands in listener.js raise failures like the following:

> Failed to gather test failure debug: TypeError: can't access dead object
> stacktrace:
> 	getPageSource@chrome://marionette/content/listener.js:1130:3
> 	dispatch/</req<@chrome://marionette/content/listener.js:482:14
> 	dispatch/<@chrome://marionette/content/listener.js:477:15
> 	MessageListener.receiveMessage*startListeners@chrome://marionette/content/listener.js:540:3
> 	registerSelf@chrome://marionette/content/listener.js:458:5
> 	@chrome://marionette/content/listener.js:1681:1
You need to log in before you can comment on or make changes to this bug.