1666217 - 2.36 - 177.16% startup_about/tp5o responsiveness/tp5o/ts_paint (windows10-64-shippable, windows10-64-shippable-qr, windows7-32-shippable) regression on push 2da9fde7a1095a35fbdcc37d2b8d103cf9935507 (Thu September 17 2020)

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a talos performance regression from push 2da9fde7a1095a35fbdcc37d2b8d103cf9935507. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

177% tp5o responsiveness windows10-64-shippable-qr opt e10s stylo 1.45 -> 4.03
148% tp5o_webext responsiveness windows10-64-shippable opt e10s stylo 2.33 -> 5.77
135% tp5o_webext responsiveness windows7-32-shippable opt e10s stylo 1.94 -> 4.57
59% about_preferences_basic windows10-64-shippable opt e10s stylo 121.39 -> 193.13
46% about_preferences_basic windows10-64-shippable-qr opt e10s stylo 128.99 -> 188.36
36% about_preferences_basic windows7-32-shippable opt e10s stylo 120.48 -> 164.15
18% ts_paint windows7-32-shippable opt e10s stylo 386.50 -> 457.42
16% ts_paint_webext windows7-32-shippable opt e10s stylo 393.75 -> 456.17
14% sessionrestore windows7-32-shippable opt e10s stylo 569.08 -> 646.83
13% ts_paint_webext windows10-64-shippable-qr opt e10s stylo 387.75 -> 438.50
13% ts_paint_webext windows10-64-shippable opt e10s stylo 385.67 -> 436.08
12% ts_paint windows10-64-shippable-qr opt e10s stylo 386.00 -> 433.67
12% startup_about_home_paint windows7-32-shippable opt e10s stylo 719.50 -> 803.08
11% ts_paint windows10-64-shippable opt e10s stylo 386.17 -> 428.58
10% sessionrestore_no_auto_restore windows7-32-shippable opt e10s stylo 625.12 -> 690.17
10% startup_about_home_paint_realworld_webextensions windows7-32-shippable opt e10s stylo 758.33 -> 836.42
8% sessionrestore_no_auto_restore windows10-64-shippable opt e10s stylo 633.71 -> 685.08
8% startup_about_home_paint windows10-64-shippable opt e10s stylo 760.08 -> 821.67
2% tp5o_webext windows10-64-shippable opt e10s stylo 353.68 -> 362.02

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Simon Giesecke [:sg] [he/him]]

I think this was backed out by https://hg.mozilla.org/integration/autoland/rev/44df5773b68f

Comment 2

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Yes Simon, sorry. I saw that but I missed to update the status accordingly.

Comment 3

[Andrew McCreight [:mccr8]]

(In reply to Simon Giesecke [:sg] [he/him] from comment #1)

I think this was backed out by https://hg.mozilla.org/integration/autoland/rev/44df5773b68f

It looks to me like this got relanded after that so this should be reopened: https://hg.mozilla.org/integration/autoland/log/tip/dom/indexedDB/ActorsParent.cpp

It looks the same on m-c: https://hg.mozilla.org/mozilla-central/log/tip/dom/indexedDB/ActorsParent.cpp

Am I misunderstanding something?

Comment 4

[Simon Giesecke [:sg] [he/him]]

Well, the patches for the bug re-landed, but I somehow suspect that this is related to the same issue as Bug 1665798, and the code causing is is disabled. I might be wrong about that though. But in that case we should see a new performance regression now, right?

Comment 5

[Florin Strugariu [:Bebe]]

the initial patch had a awsy regression also:
== Change summary for alert #26973 (as of Thu, 17 Sep 2020 22:58:20 GMT) ==

Regressions:

10% Heap Unclassified windows10-64-shippable opt 51,421,506.99 -> 56,578,551.82
10% Heap Unclassified windows7-32-shippable opt 37,147,089.44 -> 40,856,336.09
6% Heap Unclassified windows10-64-shippable-qr opt tp6 71,043,637.64 -> 75,102,566.49
5% Heap Unclassified windows7-32-shippable opt tp6 51,265,853.89 -> 53,892,838.48
5% Heap Unclassified windows10-64-shippable opt tp6 68,448,788.51 -> 71,873,840.54
4% Resident Memory windows10-64-shippable opt tp6 659,362,949.45 -> 687,703,896.71
4% Resident Memory windows10-64-shippable opt 529,885,179.35 -> 550,617,913.33
3% Resident Memory windows10-64-shippable-qr opt tp6 715,528,504.74 -> 737,961,173.90
3% Resident Memory windows10-64-shippable-qr opt 566,577,921.86 -> 583,136,813.25
1% Base Content JS windows10-64-shippable-qr opt 3,074,036.89 -> 3,114,924.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26973

Comment 6

[Florin Strugariu [:Bebe]]

And the backout alert
== Change summary for alert #27000 (as of Sat, 19 Sep 2020 11:23:00 GMT) ==

Improvements:

8% Heap Unclassified windows7-32-shippable opt 41,090,065.60 -> 37,654,336.54
8% Heap Unclassified windows10-64-shippable opt 56,642,675.10 -> 52,031,169.91
6% Heap Unclassified windows10-64-shippable opt tp6 72,121,756.54 -> 67,769,833.83
5% Heap Unclassified windows10-64-shippable-qr opt tp6 75,532,745.72 -> 72,079,390.82
4% Resident Memory windows10-64-shippable opt tp6 687,312,772.66 -> 657,666,950.57
3% Resident Memory windows10-64-shippable opt 549,488,399.23 -> 530,446,635.79
3% Base Content Resident Unique Memory windows10-64-shippable opt 11,907,328.00 -> 11,558,058.67
3% Resident Memory windows10-64-shippable-qr opt 582,825,322.73 -> 566,402,454.50

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=27000

Comment 7

[Florin Strugariu [:Bebe]]

Also a raptor regression:
== Change summary for alert #26977 (as of Thu, 17 Sep 2020 23:12:37 GMT) ==

Regressions:

3% raptor-tp6-twitter-firefox-cold fcp windows10-64-shippable-qr opt webrender 215.75 -> 223.25
3% raptor-tp6-instagram-firefox-cold fcp windows7-32-shippable opt 215.21 -> 221.33
3% raptor-tp6-twitter-firefox-cold windows10-64-shippable-qr opt webrender 482.04 -> 495.31
2% raptor-tp6-paypal-firefox-cold loadtime windows10-64-shippable-qr opt webrender 849.04 -> 867.17

Improvements:

15% raptor-tp6-bing-firefox-cold loadtime macosx1014-64-shippable opt 628.25 -> 533.08
13% raptor-tp6-twitter-firefox-cold fcp macosx1014-64-shippable opt 330.08 -> 285.67
12% raptor-tp6-microsoft-firefox-cold loadtime macosx1014-64-shippable opt 1,081.83 -> 947.33
12% raptor-tp6-microsoft-firefox-cold macosx1014-64-shippable opt 838.19 -> 735.77
12% raptor-tp6-paypal-firefox-cold loadtime macosx1014-64-shippable opt 1,409.83 -> 1,237.75
12% raptor-tp6-microsoft-firefox-cold fcp macosx1014-64-shippable opt 796.92 -> 703.58
11% raptor-tp6-paypal-firefox-cold macosx1014-64-shippable opt 1,054.41 -> 939.35
10% raptor-tp6-twitter-firefox-cold macosx1014-64-shippable opt 725.42 -> 650.99
10% raptor-tp6-paypal-firefox-cold fcp macosx1014-64-shippable opt 875.25 -> 787.67

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26977

Comment 8

[Florin Strugariu [:Bebe]]

Raptor backout alert:
== Change summary for alert #26997 (as of Sat, 19 Sep 2020 11:00:56 GMT) ==

Regressions:

17% raptor-tp6-paypal-firefox-cold loadtime macosx1014-64-shippable opt 1,225.69 -> 1,433.25
15% raptor-tp6-microsoft-firefox-cold loadtime macosx1014-64-shippable opt 949.15 -> 1,094.92
15% raptor-tp6-paypal-firefox-cold macosx1014-64-shippable opt 933.33 -> 1,070.92
14% raptor-tp6-microsoft-firefox-cold macosx1014-64-shippable opt 736.18 -> 841.98
13% raptor-tp6-microsoft-firefox-cold fcp macosx1014-64-shippable opt 702.77 -> 797.08
13% raptor-tp6-paypal-firefox-cold fcp macosx1014-64-shippable opt 784.38 -> 889.08
12% raptor-tp6-google-mail-firefox-cold macosx1014-64-shippable opt 439.58 -> 493.94

Improvements:

14% raptor-tp6-twitch-firefox-cold loadtime windows7-32-shippable opt 1,301.50 -> 1,117.67
13% raptor-tp6-twitch-firefox-cold fcp windows7-32-shippable opt 97.81 -> 85.00
12% raptor-tp6-netflix-firefox-cold loadtime windows7-32-shippable opt 1,036.58 -> 915.50
10% raptor-tp6-netflix-firefox-cold windows7-32-shippable opt 543.60 -> 488.95
9% raptor-tp6-twitch-firefox-cold windows7-32-shippable opt 304.01 -> 278.13
7% raptor-tp6-twitter-firefox-cold fcp windows7-32-shippable opt 230.50 -> 215.17
6% raptor-tp6-netflix-firefox-cold loadtime windows10-64-shippable-qr opt webrender 1,033.58 -> 970.67

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26997

Comment 9

[Florin Strugariu [:Bebe]]

As this bug caused multiple regressions on different platforms I would ask for a new look.

please close the bug if it's the same cause

Comment 10

[Simon Giesecke [:sg] [he/him]]

I don't know. I assume this is not an issue with what's eventually landed with Bug 1663924, but i don't know how to verify that. From my point of view, it's safe to close it for now, and reopen it if it turns out my assumption is wrong.

Comment 11

[Julien Cristau [:jcristau]]

Can you check comment 10?

Comment 12

[Florin Strugariu [:Bebe]]

Regression alert on browsertime
== Change summary for alert #26985 (as of Fri, 18 Sep 2020 04:53:50 GMT) ==

Regressions:

18% youtube-watch ContentfulSpeedIndex android-hw-p2-8-0-android-aarch64-shippable opt warm 568.67 -> 670.42
2% wikipedia Similarity2D android-hw-p2-8-0-android-aarch64-shippable opt cold 0.94 -> 0.92

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26985

Comment 13

[Florin Strugariu [:Bebe]]

(In reply to Julien Cristau [:jcristau] from comment #11)

Can you check comment 10?

Yes you are right all regressions where fixed by Bug 1663924