Closed Bug 1663924 Opened 4 years ago Closed 4 years ago

Further migration to IDB_TRY* and Result in IndexedDB

Categories

(Core :: Storage: IndexedDB, task)

task

Tracking

()

RESOLVED FIXED
85 Branch

People

(Reporter: sg, Assigned: sg)

References

(Regressed 1 open bug)

Details

Attachments

(130 files, 2 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
No description provided.
Attachment #9174695 - Attachment description: Bug 1663924 - Use IDB_TRY_VAR in GetSandboxInternal. r=#dom-workers-and-storage → Bug 1663924 - Use IDB_TRY in GetSandboxInternal. r=#dom-workers-and-storage

Comment on attachment 9174693 [details]
Bug 1663924 - Use IDB_TRY in Create*Tables and use a ExecuteSimpleSQLSequence helper function. r=#dom-workers-and-storage

Revision D89617 was moved to bug 1664143. Setting attachment 9174693 [details] to obsolete.

Attachment #9174693 - Attachment is obsolete: true
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/922826623aa8
Change MakeCompressedIndexDataValues to return a Result<> rather than use output parameters. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/6fe0a9076b6d
Simplify MakeCompressedIndexDataValues using std::accumulate. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e7a8741fcc5f
Create single-element arrays in-place. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e2a94c1a1ac6
Replace output parameter in DatabaseOperationBase::IndexDataValuesFromUpdateInfos by mozilla::Result. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/f93e7745be29
Make use of TransformIntoNewArrayAbortOnErr in IDBObjectStore::AddOrPut. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/bddb08e90232
Use IDB_TRY_VAR in DeserializeStructuredCloneFile and refactor it. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/2dc209620c7c
Use IDB_TRY in GetSandboxInternal. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/700624d6e60b
Use IDB_TRY* in ReadCompressedIndexDataValuesFromBlob. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/35caac40049d
Removed unused IDB_ENSURE_SUCCESS macro. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/af39c9bbd8fd
Removed IDB_ENSURE_TRUE macro and convert its uses to IDB_TRY. r=dom-workers-and-storage-reviewers,janv
Keywords: leave-open
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cbb087487500
Make use of IDB_TRY* in ReadCompressedIndexDataValuesFromSource and use switch. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/fba838c327e4
Make use of IDB_TRY* in GetStructuredCloneReadInfoFromBlob. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/012f083e52e7
Make use of IDB_TRY* in GetStructuredCloneReadInfoFromExternalBlob. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/0201bc764cda
Make use of IDB_TRY* in GetStructuredCloneReadInfoFromSource and use switch. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/4b9800dd2537
Make use of IDB_TRY* in MakeCompressedIndexDataValues. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/76b8c025e65c
Use ToResultInvoke in ReadCompressedIndexDataValues and fix some output parameter signatures. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/12c247af600c
Use IDB_TRY in ReadCompressedNumber. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/2613b389230f
Change GetCurrentPermission to return a Result rather than use an output parameter. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/a83e4ce20c39
Change CheckPermission to return a Result rather than use an output parameter. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/fe5eb72e6147
Use IDB_TRY_VAR in GetDatabaseFileURL. r=dom-workers-and-storage-reviewers,janv
Attachment #9175771 - Attachment description: Bug 1663924 - Split BorrowedCachedStatement from CachedStatement. r=#dom-workers-and-storage → Bug 1663924 - Split BorrowedStatement from CachedStatement. r=#dom-workers-and-storage
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ccf09dfa817a
Change GetCachedStatement to return a Result rather than use an output parameter. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/014bcf5d13b9
Use IDB_TRY* in CreateStorageConnection. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/30394cbcaaf6
Extract CreateAndExecuteSingleStepStatement function. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/fcaed021597c
Extract CollectWhileHasResult function. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/4c22c3c8aa28
Use CollectWhileHasResult at more places. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/884e286909f9
Add ScopedLogExtraInfo. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e0b0b3a19544
Use ExecuteCachedStatement where possible. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/8d28611ac9b2
Use IDB_TRY in ExecuteCachedStatement. r=dom-workers-and-storage-reviewers,ttung
Blocks: 1665565
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8cc5dcc86f40
Change GetCachedStatement to return a Result rather than use an output parameter. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/0c37ce712c2c
Use IDB_TRY* in CreateStorageConnection. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/a80f52551e3a
Extract CreateAndExecuteSingleStepStatement function. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/dde2058c20ef
Extract CollectWhileHasResult function. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e02961ac5ee7
Use CollectWhileHasResult at more places. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e3196b68932c
Add ScopedLogExtraInfo. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/4e51461c369c
Use ExecuteCachedStatement where possible. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/309354891d60
Use IDB_TRY in ExecuteCachedStatement. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/9353759cc783
Use std::find_if in ConnectionPool::IdleTimerCallback. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/2da9fde7a109
Use std::any_of/IDB_TRY in FactoryOp::DirectoryOpen. r=dom-workers-and-storage-reviewers,ttung

Fixed the leak and relanded.

Flags: needinfo?(sgiesecke)
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecb3b5a37c2d
Change GetCachedStatement to return a Result rather than use an output parameter. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/467e862e358f
Use IDB_TRY* in CreateStorageConnection. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/84b37a26eea9
Extract CreateAndExecuteSingleStepStatement function. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/542423d693fa
Extract CollectWhileHasResult function. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/b5074643eab4
Use CollectWhileHasResult at more places. r=dom-workers-and-storage-reviewers,janv
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55cef10dbcf7
Use std::find_if in ConnectionPool::IdleTimerCallback. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd066c59eeb1
Use std::any_of/IDB_TRY in FactoryOp::DirectoryOpen. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/ad6486e23ae5
Add ScopedLogExtraInfo. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/8717e9337514
Use ExecuteCachedStatement where possible. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/9713437574b0
Use IDB_TRY in ExecuteCachedStatement. r=dom-workers-and-storage-reviewers,ttung

(In reply to Natalia Csoregi [:nataliaCs] from comment #48)

Backed out for multiple failures

backout: https://hg.mozilla.org/integration/autoland/rev/44df5773b68ff4bce230ba77a3caddb7e73da525

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=2da9fde7a1095a35fbdcc37d2b8d103cf9935507&searchStr=Windows%2C10%2Cx64%2CWebRender%2CShippable%2Copt

== Change summary for alert #26994 (as of Sat, 19 Sep 2020 00:20:07 GMT) ==

Improvements:

61% tp5o responsiveness windows10-64-shippable-qr opt e10s stylo 3.88 -> 1.50
60% tp5o_webext responsiveness windows10-64-shippable opt e10s stylo 5.89 -> 2.35
57% tp5o_webext responsiveness windows7-32-shippable opt e10s stylo 4.42 -> 1.90
37% about_preferences_basic windows10-64-shippable-qr opt e10s stylo 187.23 -> 117.81
35% about_preferences_basic windows10-64-shippable opt e10s stylo 186.84 -> 122.23
31% about_preferences_basic windows7-32-shippable opt e10s stylo 166.40 -> 115.34
14% ts_paint windows7-32-shippable opt e10s stylo 458.31 -> 395.42
13% ts_paint_webext windows7-32-shippable opt e10s stylo 454.08 -> 394.00
13% ts_paint_webext windows10-64-shippable-qr opt e10s stylo 439.94 -> 384.92
13% ts_paint_webext windows10-64-shippable opt e10s stylo 434.58 -> 380.25
10% sessionrestore windows7-32-shippable opt e10s stylo 643.00 -> 577.75
10% ts_paint windows10-64-shippable-qr opt e10s stylo 433.00 -> 389.17
10% sessionrestore_no_auto_restore windows7-32-shippable opt e10s stylo 698.18 -> 631.67
9% ts_paint windows10-64-shippable opt e10s stylo 427.44 -> 387.00
9% startup_about_home_paint_realworld_webextensions windows7-32-shippable opt e10s stylo 834.50 -> 756.42
9% startup_about_home_paint windows7-32-shippable opt e10s stylo 798.81 -> 727.67
8% startup_about_home_paint windows10-64-shippable opt e10s stylo 821.44 -> 755.00
7% sessionrestore windows10-64-shippable opt e10s stylo 616.67 -> 574.25

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26994

Regressions: 1665798
Regressions: 1666471
Attachment #9175807 - Attachment is obsolete: true
Attachment #9177370 - Attachment description: Bug 1663924 - Replace output parameters by return valueson GetInfo* methods. r=#dom-workers-and-storage → Bug 1663924 - Replace output parameters by return values on GetInfo* methods. r=#dom-workers-and-storage

Convert DatabaseFunction class into lambda expression, and make more use of IDB_TRY.

Depends on D91281

Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/494ca2f00ea6
Split BorrowedStatement from CachedStatement. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/85eddcea0f11
Replace AppendInt by ToAutoCString where possible. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/60bd1f31d2a8
Use IDB_TRY and CollectWhile in DatabaseConnection::ReclaimFreePagesWhileIdle. r=dom-workers-and-storage-reviewers,ttung,janv
https://hg.mozilla.org/integration/autoland/rev/ea1f5f1f43a3
Use IDB_TRY in DatabaseOperationBase::InsertIndexTableRows. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/b317a9021db8
Use IDB_TRY_VAR with ExecuteStep. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/5c29355031d5
Use MOZ_TO_RESULT_INVOKE_TYPED in dom/indexedDB. r=dom-workers-and-storage-reviewers,janv
Flags: needinfo?(sgiesecke)
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1dde4d00179
Replace output parameter of GetFreelistCount by return value. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/41a0828b4117
Replace output parameter of PromptIfNeeded by return value. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/2e1fac84c522
Replace output parameter of GetFileSize by return value. r=dom-workers-and-storage-reviewers,ttung,janv
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3492d09974e2
Replace output parameter of ReclaimFreePagesWhileIdle by return value. r=dom-workers-and-storage-reviewers,ttung,janv
https://hg.mozilla.org/integration/autoland/rev/d4f52a013b02
Replace output parameter of CreateMutableFile by return value. r=dom-workers-and-storage-reviewers,ttung,janv
https://hg.mozilla.org/integration/autoland/rev/c54acad69383
Replace output parameter of QuotaClient::GetDirectory by return value. r=dom-workers-and-storage-reviewers,janv
Depends on: 1671132
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6976b49dbaa0
Replace output parameters of QuotaClient::GetDatabaseFilenames by return value. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/da34a95d4015
Replace output parameters of key transformation by return value. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/8d63417851f6
Remove unused duplicate DeserializeUpgradeValueHelper. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/1f7f935b9fc8
Use IDB_TRY throughout SerializeStructuredCloneFiles. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/91cdb7a5633c
Use TRY macros with PrincipalInfoToPrincipal. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/a3cdb0d15132
Replace output parameter by return value for EnsureStorageAndOriginIsInitialized. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f92e3f0e19a
Use IDB_TRY in OpenDatabaseOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3242caa1b1b7
Use IDB_TRY in OpenDatabaseOp::LoadDatabaseInformation. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/5eac8a8a951a
Use IDB_TRY in FileManager::SyncDeleteFile. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/42b727cdc4dd
Use IDB_TRY when calling QuotaClient::GetUsageForOriginInternal. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/0dcd47d8afd9
Use IDB_TRY in QuotaClient::GetUsageForOriginInternal and remove REPORT_TELEMETRY_INIT_ERR. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d081d540942e
Refactor DatabaseConnection::UpdateRefcountFunction::WillCommit. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/58bb58aa7308
Replace output parameters of KeyPath::Parse by return value. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/17518bed4c4d
Use IDB_TRY in DatabaseOperationBase::UpdateIndexValues. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/5238daa0eefc
Use IDB_TRY in DatabaseOperationBase::DeleteObjectStoreDataTableRowsWithIndexes. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8bcb585a95a
Replace output parameter of ObjectStoreHasIndexes by return value. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/47a3571a853b
Replace output parameters by return values on GetInfo* methods. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/f24307da43f0
Use IDB_TRY in Maintenance::DirectoryWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/78374c93c219
Use IDB_TRY in FactoryOp::OpenDirectory. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/74d3f8c4dc39
Use IDB_TRY in DatabaseMaintenance::DetermineMaintenanceAction. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/e57a66ba2bdc
Use IDB_TRY in DatabaseMaintenance::FullVacuum. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/9534c9cbb6f9
Use IDB_TRY in DatabaseMaintenance::CheckIntegrity. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/21157cf311f3
Use IDB_TRY in CreateIndexOp::InsertDataFromObjectStoreInternal. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/2d829a81f431
Use IDB_TRY in ObjectStoreAddOrPutRequestOp::RemoveOldIndexDataValues. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/4a7d76e83bb0
Use IDB_TRY in ObjectStoreAddOrPutRequestOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99a74296ac4b
Use CollectEach in GetStructuredCloneReadInfoFromExternalBlob. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/62c3bbd8996c
Extract and reuse SnappyUncompressStructuredCloneData. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/608c6e38c3ad
Extract and reuse CloneFileAndAppend. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/d20eee185c1d
Use IDB_TRY in CreateObjectStoreOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/88c7da0be16b
Change KeyPath::SerializeToString to use a return value. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/d413d97fe360
Use IDB_TRY in UpdateRefcountFunction::ProcessValue. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/930b2181ec7e
Use IDB_TRY in DeleteObjectStoreOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/cdd83a166391
Extract and reuse MakeAutoSavepointCleanupHandler. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/8bd0d2d13b9e
Use IDB_TRY in RenameObjectStoreOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/3aba2e347ba6
Use IDB_TRY in CreateIndexOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/ae56bf3c6b5f
Use IDB_TRY in DeleteIndexOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/8eef3a50d764
Use IDB_TRY in RenameIndexOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96d935f8042f
Use IDB_TRY in ObjectStoreDeleteRequestOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/884c16edc11c
Use IDB_TRY in ObjectStoreClearRequestOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/7b5cbb2d8dfb
Use IDB_TRY in ObjectStoreCountRequestOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/ee1a1d52c113
Use IDB_TRY in IndexGetRequestOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/dc2fdd4d9ea2
Use IDB_TRY in ContinueOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/6ba41729b48b
Use IDB_TRY in OpenOpHelper<IDBCursorType::IndexKey>::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/b4a4b0c04013
Use IDB_TRY in OpenOpHelper<IDBCursorType::Index>::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/410f61a1eda9
Use IDB_TRY in OpenOpHelper<IDBCursorType::ObjectStoreKey>::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/00e0716d16d7
Use IDB_TRY in OpenOpHelper<IDBCursorType::ObjectStore>::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/83e9825c30ba
Use IDB_TRY in IndexCountRequestOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/78776ab614b1
Use IDB_TRY in IndexGetKeyRequestOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/685ccd125648
Use IDB_TRY in ObjectStoreGetRequestOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/10ae354e74d8
Use IDB_TRY in DeleteIndexOp::RemoveReferencesToIndex. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/1100235b6357
Use IDB_TRY in CreateIndexOp::UpdateIndexDataValuesFunction. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/98d239134451
Use IDB_TRY in DatabaseOperationBase::DeleteIndexDataTableRows. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/5a01980cef83
Use IDB_TRY in OpenDatabaseOp::UpdateLocaleAwareIndex. r=dom-workers-and-storage-reviewers,ttung
Attachment #9182347 - Attachment description: Bug 1663924 - Use IDB_TRY in DatabaseConnection::CommitWriteTransaction. r=#dom-workers-and-storage → Bug 1663924 - Use IDB_TRY in DatabaseConnection::CommitWriteTransaction and DatabaseConnection::FinishWriteTransaction. r=#dom-workers-and-storage
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0aeaac526c95
Use IDB_TRY in OpenDatabaseOp::BeginVersionChange. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/37254bce47be
Use IDB_TRY in SetDefaultPragmas. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/00abe675c7f5
Use IDB_TRY in SetJournalMode. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/c128d2c4fa69
Use IDB_TRY in GetStorageConnection. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/541cce32e17d
Use IDB_TRY in PopulateResponseHelper. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/3310e6f80efe
Use IDB_TRY in DispatchAndReturnFileReferences. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/2b513e3647ca
Use IDB_TRY in DeserializeIndexValueHelper. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/7c1b582a5b4a
Use IDB_TRY in DatabaseConnection::BeginWriteTransaction. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/7dd2722deda8
Use IDB_TRY in DatabaseConnection::CommitWriteTransaction and DatabaseConnection::FinishWriteTransaction. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/37903f1f94e9
Use IDB_TRY in DatabaseConnection::StartSavepoint/ReleaseSavepoint. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/a8cead0c3a6a
Use IDB_TRY in DatabaseConnection::CheckpointInterval. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/214f5ff2f757
Use IDB_TRY in DatabaseConnection::DisableQuotaChecks. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/b6ae2ad6353d
Use IDB_TRY in DatabaseConnection::AutoSavepoint. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/21c0803b9762
Use IDB_TRY in ConnectionPool::GetOrCreateConnection. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/661bbf862f2e
Use IDB_TRY in Database::StartTransactionOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/5e4218e8f294
Use IDB_TRY in FileManager::EnsureJournalDirectory. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/41609c5a106e
Use IDB_TRY in QuotaClient::AsyncDeleteFile. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/b818d0811af3
Use IDB_TRY in QuotaClient::FlushPendingFileDeletions. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecea131d6385
Use IDB_TRY in DeleteFile. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/fdc253eda3f4
Use IDB_TRY in CursorOpBaseHelperBase::PopulateResponseFromStatement. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/1457a417541e
Use IDB_TRY in OpenDatabaseOp::VersionChangeOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/84380edabad2
Use IDB_TRY in DatabaseOperationBase::AutoSetProgressHandler::Register. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/f167d5c8ba37
Use IDB_TRY in FactoryOp::SendToIOThread. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/42fb95ae7215
Use IDB_TRY in FactoryOp::FinishOpen. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/9a702e406e93
Use IDB_TRY in FactoryOp::QuotaManagerOpen. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/f946a9db79b5
Use IDB_TRY in FactoryOp::DirectoryLockAcquired. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/567b63bf0efb
Use IDB_TRY in QuotaClient::UpgradeStorageFrom2_1To2_2. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/c718ce743dbb
Use IDB_TRY in DeleteFilesRunnable::DirectoryLockAcquired. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/59d85aecbf1d
Use IDB_TRY in Maintenance::DirectoryOpen. r=dom-workers-and-storage-reviewers,ttung

https://hg.mozilla.org/mozilla-central/rev/0aeaac526c95
https://hg.mozilla.org/mozilla-central/rev/37254bce47be
https://hg.mozilla.org/mozilla-central/rev/00abe675c7f5
https://hg.mozilla.org/mozilla-central/rev/c128d2c4fa69
https://hg.mozilla.org/mozilla-central/rev/541cce32e17d
https://hg.mozilla.org/mozilla-central/rev/3310e6f80efe
https://hg.mozilla.org/mozilla-central/rev/2b513e3647ca
https://hg.mozilla.org/mozilla-central/rev/7c1b582a5b4a
https://hg.mozilla.org/mozilla-central/rev/7dd2722deda8
https://hg.mozilla.org/mozilla-central/rev/37903f1f94e9
https://hg.mozilla.org/mozilla-central/rev/a8cead0c3a6a
https://hg.mozilla.org/mozilla-central/rev/214f5ff2f757
https://hg.mozilla.org/mozilla-central/rev/b6ae2ad6353d
https://hg.mozilla.org/mozilla-central/rev/21c0803b9762
https://hg.mozilla.org/mozilla-central/rev/661bbf862f2e
https://hg.mozilla.org/mozilla-central/rev/5e4218e8f294
https://hg.mozilla.org/mozilla-central/rev/41609c5a106e
https://hg.mozilla.org/mozilla-central/rev/b818d0811af3
https://hg.mozilla.org/mozilla-central/rev/ecea131d6385
https://hg.mozilla.org/mozilla-central/rev/fdc253eda3f4
https://hg.mozilla.org/mozilla-central/rev/1457a417541e
https://hg.mozilla.org/mozilla-central/rev/84380edabad2
https://hg.mozilla.org/mozilla-central/rev/f167d5c8ba37
https://hg.mozilla.org/mozilla-central/rev/42fb95ae7215
https://hg.mozilla.org/mozilla-central/rev/9a702e406e93
https://hg.mozilla.org/mozilla-central/rev/f946a9db79b5
https://hg.mozilla.org/mozilla-central/rev/567b63bf0efb
https://hg.mozilla.org/mozilla-central/rev/c718ce743dbb
https://hg.mozilla.org/mozilla-central/rev/59d85aecbf1d

Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20c2946db4a1
Use IDB_TRY in DeleteDatabaseOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04c80a32a900
Use IDB_TRY in DatabaseConnection::UpdateRefcountFunction. r=dom-workers-and-storage-reviewers,janv
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dafde9de1502
Use IDB_TRY in QuotaClient::UpgradeStorageFrom1_0To2_0. r=dom-workers-and-storage-reviewers,ttung,janv
https://hg.mozilla.org/integration/autoland/rev/73f3c4d57e87
Use IDB_TRY in FactoryOp::Run. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/84bf4201587c
Use IDB_TRY in DatabaseOp::Run. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/785624cc9edf
Use IDB_TRY in Maintenance::Run. r=dom-workers-and-storage-reviewers,ttung
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Regressions: 1696134
Regressions: 1700046
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: