1666347 - Misc cleanup after removal of psutil

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Ricky Stewart]

Attachment: Bug 1666347 - Delete assorted dead code after removal of vendored `psutil`

Most of the deletions here come from bug 1481612, the --with-windows-wheel option to mach vendor python, which according to that commit message "is very single-purpose: it's intended to let us vendor an unpacked
wheel for psutil on Windows". Since vendoring psutil is something we're no longer doing, we can safely just delete that added code.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:rstewart, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Ricky Stewart]

Blocked on bug 1668395.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19f707f5c097
Delete assorted dead code after removal of vendored `psutil` r=firefox-build-system-reviewers,mhentges

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for Mingw bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/948623152a6eb50555d8cb17bf92915390870c2a

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=b63acc35871b4aad7d341b13f39f330a8d5ed099&selectedTaskRun=bTUrkj0DTsCqdCcWaDjThA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=321581692&repo=autoland&lineNumber=362

Comment 6

[Cosmin Sabou [:CosminS]]

These kind of mochitest failures seem to be caused also from the push with those 4 bugs: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=b63acc35871b4aad7d341b13f39f330a8d5ed099&searchStr=linux%2Cmochitest&tochange=948623152a6eb50555d8cb17bf92915390870c2a&selectedTaskRun=B14CM09tRMy4g1mtcEsOzA.0

They failed only on Linux. Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=321584602&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=321584424&repo=autoland

Please have a look over these also, thank you.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1dd480fd638
Delete assorted dead code after removal of vendored `psutil` r=firefox-build-system-reviewers,mhentges

Comment 8

[Alexandru Michis [:malexandru]]

Backed out changeset d1dd480fd638 (Bug 1666347) for causing mochitest timeouts.

Backout link: https://hg.mozilla.org/integration/autoland/rev/00b66ccdc9b0eb2199d2d91f673439993465e895

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&fromchange=6319f8438a3a47519479f0c96e6d69b420652d02&searchStr=linux%2C18.04%2Cx64%2Copt%2Cmochitests%2Ctest-linux1804-64%2Fopt-mochitest-browser-chrome-e10s%2Cbc1&tochange=2d02a4568f897baf23809baedb0e31cd38269021&group_state=expanded&selectedTaskRun=b6ZkHCfPR4K8MpBSFgCeGQ.0

(Updated link with missing range parameter)
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&fromchange=6319f8438a3a47519479f0c96e6d69b420652d02&searchStr=mochitest&tochange=2d02a4568f897baf23809baedb0e31cd38269021&selectedTaskRun=cn-1kB7-TGyFVN_m2GAt2w.0

Failure logs:
mochitest plain: https://treeherder.mozilla.org/logviewer?job_id=321727005&repo=autoland&lineNumber=3215
browser chrome: https://treeherder.mozilla.org/logviewer?job_id=321733827&repo=autoland&lineNumber=5088
devtools: https://treeherder.mozilla.org/logviewer?job_id=321729298&repo=autoland&lineNumber=2511

As Cosmin mentioned before, I am only seeing failures on Linux.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ce536574e74
Delete assorted dead code after removal of vendored `psutil` r=firefox-build-system-reviewers,mhentges

Comment 10

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1666345, Bug 1661624, Bug 1667152, Bug 1666347) for causing mochitest failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=OQU6G-FMSLSSsVui-mLopA.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=8ce536574e740f79b2845f87a4916a2cd4a9f545

Failure log example: https://treeherder.mozilla.org/logviewer?job_id=321931842&repo=autoland&lineNumber=3421

Backout: https://hg.mozilla.org/integration/autoland/rev/dc0e5a789feb83a0c8b020907d6d7c270825a22d

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This issue hit again after a different push landed (bug 1665844). The docker image ubuntu1804-test (among other docker images) got updated.

Joel, can you take a look what got updated in the docker image(s) and triggers there Linux mochitest failures? Examples:

• https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=19f707f5c097583684c83766e8b230b63eff5953
• https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=bc0c64106daa652aa2297e9965f23978c1e0f5cf&selectedTaskRun=QHnRC3_7TOmpItI9nAEIVg.0

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

other than Ricky's work in the docker file:
https://hg.mozilla.org/mozilla-central/log/tip/taskcluster/docker/recipes/ubuntu1804-test-system-setup.sh

I don't see any other changes since August. I am not sure who should look at this, I suspect the ubuntu 18 docker images are out of date or if they were rebuilt would fail.

I am not sure who is the owner of the linux docker image (cc'ing managers of various automation teams), it sounds like we need to investigate if the current image can be rebuilt and used successfully?

Comment 13

[Mike Hommey [:glandium]]

It's the good old "ubuntu images are not reproducible, and ubuntu has updated packages with side effects on our tests" again.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18d9b3798b38
Delete assorted dead code after removal of vendored `psutil` r=firefox-build-system-reviewers,rstewart

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/18d9b3798b38