1666485 - Move nsIDocShell::CreatedDynamically to BrowsingContext

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[u608768]

This was part of the patchset for bug 1572084, but this is needed for bug 1646573.

Comment 1

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

Wasn't this fixed last week
https://searchfox.org/mozilla-central/rev/b58ca45005fe02077c92779483d1b60e9a49687c/docshell/base/nsDocShell.cpp#3126,3128,3135

Comment 2

[u608768]

(In reply to Olli Pettay [:smaug] from comment #1)

Wasn't this fixed last week
https://searchfox.org/mozilla-central/rev/b58ca45005fe02077c92779483d1b60e9a49687c/docshell/base/nsDocShell.cpp#3126,3128,3135

oh, I was working on a very outdated tree. I don't think it needs to be a synced field though, I'll use this to make it non-synced.

Comment 3

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

Well, session history needs it as sync'ed field.

Comment 4

[u608768]

Attachment: Bug 1666485 - Make BrowsingContext::CreatedDynamically non-synced, r?kmag,nika

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a81b4130ac14
Make BrowsingContext::CreatedDynamically non-synced, r=nika,kmag

Comment 6

[Atila Butkovits]

Backed out changeset for causing bustages on BrowsingContext.

Backout link: https://hg.mozilla.org/integration/autoland/rev/28a83ee55db400c9a498106d25756822de354427

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=Fz0fdXVPT-udzbZYMe81iw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=a81b4130ac14be5a76f36b85e3308e3a78e343b6&searchStr=linux%2Cx64%2Copt%2Cbuild-linux64%2Fopt%2Cb

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316486453&repo=autoland&lineNumber=48347

Comment 7

[u608768]

bad rebase

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26fd00ccaea4
Make BrowsingContext::CreatedDynamically non-synced, r=nika,kmag

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/26fd00ccaea4