1646573 - Fix GetInProcessParent usage in CheckParentFrames and WindowShouldMatchActiveTab

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P2)

Description

[Kris Maglione [:kmag]]

It isn't Fission-compatible.

Comment 1

[Neha Kochar [:neha]]

Seems like it'd break extension content scripts (perhaps even w/ a crash?) - needs to be fixed in M6b.

Comment 2

[Neha Kochar [:neha]]

Kris said he can do this.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1646573: Part 1 - Fix GetInProcessParent usage in WindowShouldMatchActiveTab. r=nika,zombie

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1646573: Part 2 - Fix GetInProcessParent usage in CheckParentFrames. r=zombie

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1646573: Part 3 - Fix OriginalFrameSrcLoad with DocumentChannel. r=mattwoodrow

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8ef2e9238c1
Part 1 - Fix GetInProcessParent usage in WindowShouldMatchActiveTab. r=zombie,nika
https://hg.mozilla.org/integration/autoland/rev/18dafc9d0c41
Part 2 - Fix GetInProcessParent usage in CheckParentFrames. r=zombie

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd7ec0e4fea4
Part 3 - Fix OriginalFrameSrcLoad with DocumentChannel. r=mattwoodrow

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_ext_contentscript_activeTab.html

backout: https://hg.mozilla.org/integration/autoland/rev/d7d553bb57ffc6fc62e55e2c214768cf52b08c05

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=WyYcXEf8QhOjLIZcBetpkA.0&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-plain-fis-e10s%2C6&revision=cd7ec0e4fea49d2f59d759a10ed0d83efa412ade

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316412741&repo=autoland&lineNumber=7746

[task 2020-09-22T22:30:58.981Z] 22:30:58 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_contentscript_activeTab.html | In original page, script is injected into base page and original frames - Expected: about:blank,mochi.test,test1.example.com, Actual: about:blank,mochi.test,test1.example.com
[task 2020-09-22T22:30:58.981Z] 22:30:58 INFO - Buffered messages finished
[task 2020-09-22T22:30:58.982Z] 22:30:58 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_contentscript_activeTab.html | Test timed out.
[task 2020-09-22T22:30:58.982Z] 22:30:58 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2020-09-22T22:30:58.982Z] 22:30:58 INFO - reportError@SimpleTest/TestRunner.js:143:22
[task 2020-09-22T22:30:58.982Z] 22:30:58 INFO - TestRunner._checkForHangs@SimpleTest/TestRunner.js:165:18
[task 2020-09-22T22:30:59.811Z] 22:30:59 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-09-22T22:30:59.812Z] 22:30:59 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_contentscript_activeTab.html | Extension left running at test shutdown
[task 2020-09-22T22:30:59.813Z] 22:30:59 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2020-09-22T22:30:59.813Z] 22:30:59 INFO - ExtensionTestUtils.loadExtension/<@SimpleTest/ExtensionTestUtils.js:117:18
[task 2020-09-22T22:30:59.813Z] 22:30:59 INFO - executeCleanupFunction@SimpleTest/SimpleTest.js:1593:13
[task 2020-09-22T22:30:59.814Z] 22:30:59 INFO - SimpleTest.finish@SimpleTest/SimpleTest.js:1607:3
[task 2020-09-22T22:30:59.815Z] 22:30:59 INFO - killTest@SimpleTest/TestRunner.js:152:22
[task 2020-09-22T22:30:59.840Z] 22:30:59 INFO - GECKO(6383) | Console message: [JavaScript Error: "SecurityError: Permission denied to access property "windowGlobalChild" on cross-origin object"]
[task 2020-09-22T22:30:59.841Z] 22:30:59 INFO - GECKO(6383) | getInnerWindowID@resource://gre/modules/ExtensionUtils.jsm:114:3

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b8ef2e9238c1
https://hg.mozilla.org/mozilla-central/rev/18dafc9d0c41

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec8c384530a1
Part 3 - Fix OriginalFrameSrcLoad with DocumentChannel. r=mattwoodrow

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ec8c384530a1