1666566 - Bump the profile format version to launch Marker Schema

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Greg Tatum [:gregtatum]]

This bug will serve as the official launch of the marker schema feature.

Here is the final checklist

1. Gecko: Land initial marker schema work Bug 1640999
2. Front-end: Land all marker schema UI changes, but use front-end schema (Done)
3. Gecko: Complete marker schema for all markers Bug 1661394
4. Front-end: Version bump + marker schema processing (Ready, needs to be merged)
5. Gecko: Version bump (this bug)

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I've got a 1-character (!) patch ready, I'll add it to the review stack of bug 1675409 (the last piece of meta bug 1661394).
But I will probably not land it at the same time, to leave a gap between them, and to make sure the frontend is ready. Greg, happy to discuss timing with you...

WIP Try, using deploy preview 2785: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=88f47d1633615dc5d678817db35480692619e43f

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1666566 - Bump Gecko profile version to 22, to use marker schema - r?gregtatum

Depends on D96054

Comment 3

[Greg Tatum [:gregtatum]]

This is good to go, the front-end changes have been deployed.

https://github.com/firefox-devtools/profiler/pull/3059

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d8af8533fd4
Bump Gecko profile version to 22, to use marker schema - r=gregtatum

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba3967802e66
Backed out 24 changesets (bug 1666566, bug 1675409) for causing hazard failures in profiler/core/platform.cpp

Comment 6

[Alexandru Michis [:malexandru]]

Backed out 24 changesets (Bug 1666566, Bug 1675409) for causing hazard failures in profiler/core/platform.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/ba3967802e66c1c3f90170d8f417b0182c514e1d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=f59bfe8ee9818eb21e824f82256c784564323da8&searchStr=linux%2Cx64%2Cdebug%2Chazard-linux64-haz%2Fdebug%2Ch&tochange=ba3967802e66c1c3f90170d8f417b0182c514e1d&selectedTaskRun=DzR3v1ZwSlujunDtsMi_MQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=322065268&repo=autoland&lineNumber=13788

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fd8d2e0ae94
Bump Gecko profile version to 22, to use marker schema - r=gregtatum

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2fd8d2e0ae94

Comment 9

[Razvan Maries]

Backed out as requested: https://hg.mozilla.org/integration/autoland/rev/9d797387f57c6f7256d94f2d9c4a4b3576de3745

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a730f6de0e2
Bump Gecko profile version to 22, to use marker schema - r=gregtatum

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout got merged earlier: https://hg.mozilla.org/mozilla-central/rev/9d797387f57c6f7256d94f2d9c4a4b3576de3745

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6a730f6de0e2d848c20bd3cba9fbf95aa4899c02