1666626 - Update throbber in the "About Firefox" always uses the low-res image

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Kirill Grouchnikov]

Attachment: firefox-update.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

This is in the latest stable version of Firefox 81.0 on macOS 10.15.6

Go to Firefox -> About Firefox and observe the visuals

Actual results:

1. The little circular progress indication during update check is not Retina-quality. It is noticeable low-resolution
2. There is a thin light line along the right edge of the "About" screen main content

See the attached screenshot

Expected results:

1. Circular progress should be high-resolution
2. No light line along the right edge of the content

Comment 1

[Kirill Grouchnikov]

One more thing - when the system preference is set to Dark mode, the "About Firefox" window still uses the light title bar.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Stephen A Pohl [:spohl]]

(In reply to Kirill Grouchnikov from comment #1)

One more thing - when the system preference is set to Dark mode, the "About Firefox" window still uses the light title bar.

This is covered by bug 1517182.

Comment 4

[Stephen A Pohl [:spohl]]

Not sure what the best component for this is, but it isn't widget:cocoa.

Comment 5

[Cristian Fogel [:cfogel]]

Attachment: ff.png

In an attempt to confirm the issue, I've taken several older issues.
As far as the attachment goes, can observe 79.0, 80.0, 81.0 and the initial attachment from the bug.

Any chance the low resolution - pixelation might be from the zoom-in over the image?
For my case that was what seemed to be at fault.

Comment 6

[Cristian Fogel [:cfogel]]

There is a thin light line along the right edge of the "About" screen main content

This issue appears to be limited to beta(82.0b8, 82.0b9)/RC as with nightly it's not visible.
In regards to it, filed bug 1670559 for separate tracking and debugging.

Comment 7

[Wayne Mery (:wsmwk)]

Kirill, do you still see this problem

Using developer edition 110, I do not see a white line.
I can't speak to the quality of the spinner.

Comment 9

[Dão Gottwald [:dao]]

So it turns out the code for selecting the throbber image is broken:

https://searchfox.org/mozilla-central/rev/d9dbf648b2f7557f6f06d27cce58546cc539cb2b/browser/base/content/aboutDialog.css#104-106

... doesn't work because it's an HTML image with the source hardcoded:

https://searchfox.org/mozilla-central/rev/d9dbf648b2f7557f6f06d27cce58546cc539cb2b/browser/components/preferences/main.inc.xhtml#516

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Meh, this is rather trivial to fix....

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1666626 - Simplify update throbbers. r=dao,Gijs

We have no XUL throbbers anymore, so remove the html difference.

We could use <img srcset="..."> instead of image-set() in css, though
that'd mean a bit of duplication in about:preferences at least.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f66e0995f7a8
Simplify update throbbers. r=dao,Gijs,settings-reviewers

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f66e0995f7a8