Closed Bug 1666775 Opened 1 month ago Closed 1 month ago

Pip player is shown for audio only demo

Categories

(Toolkit :: Video/Audio Controls, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
83 Branch
Tracking Status
relnote-firefox --- 81+
firefox-esr78 --- unaffected
firefox81 --- verified
firefox82 --- verified
firefox83 --- verified

People

(Reporter: Gabi, Assigned: mconley)

References

(Regressed 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image Pipaudio.png

Affected versions

  • Fx 82.0b2
  • Fx 83.0a1

Affected platforms

  • Windows 10x84
  • Ubuntu 16.4
  • macOS 10.12

Steps to reproduce

  1. Launch Firefox

  2. Access http://www.hochmuth.com/mp3/Vivaldi_Sonata_eminor_.mp3

  3. Observe the Pip Player on the right

Expected result
Pip player should not be shown for audio only file

Actual result
Pip player is shown for audio only demo

Suggested Severity: S3

Will find the regression asap.

Has Regression Range: --- → no
Has STR: --- → yes

I can reproduce the issue on nightly83.0a1 Windows10. But the toggler icon appears on left side.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0ea4a897ea2ff5bf06ae4eccdfbb004d90a7871a&tochange=8c8f6d93ade332edc31bba40a8bddb6aab1ef963

Regressed by: 1664899
QA Whiteboard: [qa-regression-triage]
Has Regression Range: no → yes

Yikes, we're shipping this with 81, as per bug 1664899

Flags: needinfo?(mconley)

On it.

Assignee: nobody → mconley
Flags: needinfo?(mconley)

This only occurs for <video> elements that have no video frames. <audio> elements are unaffected.

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38353040d4e7
Make sure to hide the new Picture-in-Picture toggle on audio-only <video> elements. r=Gijs
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

Did you want to nominate this for Beta & Release uplift? Please do so if yes :)

Flags: needinfo?(mconley)

Comment on attachment 9177676 [details]
Bug 1666775 - Make sure to hide the new Picture-in-Picture toggle on audio-only <video> elements. r?Gijs!

Beta/Release Uplift Approval Request

  • User impact if declined: Users might see the new Picture-in-Picture toggle as a ghostly presence in the background of the built-in audio player.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This fix was a one-liner to include instructions to hide the new toggle variation that's going out as part of Shirley. We had similar instructions for the original toggle, which we knew worked. This one also comes with an automated test.
  • String changes made/needed: None.
Flags: needinfo?(mconley)
Attachment #9177676 - Flags: approval-mozilla-release?
Attachment #9177676 - Flags: approval-mozilla-beta?

Comment on attachment 9177676 [details]
Bug 1666775 - Make sure to hide the new Picture-in-Picture toggle on audio-only <video> elements. r?Gijs!

Approved for 82.0b5. Would be great if QA could verify this before Wednesday's planned 81.0.1 go-to-build.

Attachment #9177676 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9177676 [details]
Bug 1666775 - Make sure to hide the new Picture-in-Picture toggle on audio-only <video> elements. r?Gijs!

Approved for 81.0.1.

Attachment #9177676 - Flags: approval-mozilla-release? → approval-mozilla-release+

Verified issue as fixed with Firefox 82.0b5 and Nightly 83.0a1 on Windows 10x64, Ubuntu 16.4, and macOS 12.6.

Added to the Firefox 81.0.1 relnotes:

Fixed Picture-in-Picture controls being visible on audio-only page elements

Verified issue as fixed with Firefox 81.0.1 on Windows 10x64, macOS 12.6, and Ubuntu 16.4.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.