1666775 - Pip player is shown for audio only demo

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: Pipaudio.png

Affected versions

• Fx 82.0b2
• Fx 83.0a1

Affected platforms

• Windows 10x84
• Ubuntu 16.4
• macOS 10.12

Steps to reproduce

1. Launch Firefox

2. Access http://www.hochmuth.com/mp3/Vivaldi_Sonata_eminor_.mp3

3. Observe the Pip Player on the right

Expected result
Pip player should not be shown for audio only file

Actual result
Pip player is shown for audio only demo

Suggested Severity: S3

Will find the regression asap.

Comment 1

[Alice0775 White]

I can reproduce the issue on nightly83.0a1 Windows10. But the toggler icon appears on left side.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0ea4a897ea2ff5bf06ae4eccdfbb004d90a7871a&tochange=8c8f6d93ade332edc31bba40a8bddb6aab1ef963

Comment 2

[Alice0775 White]

Regression window with media.videocontrols.picture-in-picture.video-toggle.mode=2:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6355e6901d9896d8e85e45fa95b37397283e50c4&tochange=c2260bc5bbcffb9aaf56f858bdc98e551c607ea2

Comment 3

[:Gijs (he/him)]

Yikes, we're shipping this with 81, as per bug 1664899

Comment 4

[Mike Conley (:mconley) (:⚙️)]

On it.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

This only occurs for <video> elements that have no video frames. <audio> elements are unaffected.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1666775 - Make sure to hide the new Picture-in-Picture toggle on audio-only <video> elements. r?Gijs!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38353040d4e7
Make sure to hide the new Picture-in-Picture toggle on audio-only <video> elements. r=Gijs

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/38353040d4e7

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Beta & Release uplift? Please do so if yes :)

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9177676 [details]
Bug 1666775 - Make sure to hide the new Picture-in-Picture toggle on audio-only <video> elements. r?Gijs!

Beta/Release Uplift Approval Request

• User impact if declined: Users might see the new Picture-in-Picture toggle as a ghostly presence in the background of the built-in audio player.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This fix was a one-liner to include instructions to hide the new toggle variation that's going out as part of Shirley. We had similar instructions for the original toggle, which we knew worked. This one also comes with an automated test.
• String changes made/needed: None.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9177676 [details]
Bug 1666775 - Make sure to hide the new Picture-in-Picture toggle on audio-only <video> elements. r?Gijs!

Approved for 82.0b5. Would be great if QA could verify this before Wednesday's planned 81.0.1 go-to-build.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6971f3e93387

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9177676 [details]
Bug 1666775 - Make sure to hide the new Picture-in-Picture toggle on audio-only <video> elements. r?Gijs!

Approved for 81.0.1.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/3b38ff0386d4

Comment 15

[Gabi Cheta [:Gabi] Desktop QA]

Verified issue as fixed with Firefox 82.0b5 and Nightly 83.0a1 on Windows 10x64, Ubuntu 16.4, and macOS 12.6.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Added to the Firefox 81.0.1 relnotes:

Fixed Picture-in-Picture controls being visible on audio-only page elements

Comment 17

[Gabi Cheta [:Gabi] Desktop QA]

Verified issue as fixed with Firefox 81.0.1 on Windows 10x64, macOS 12.6, and Ubuntu 16.4.