1664899 - Set Mode 2 in the right position as the default Picture-in-Picture toggle

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, task)

Description

[Mike Conley (:mconley) (:⚙️)]

Data science is in - we believe Mode 2, right position is the winner.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1664899 - Set the Picture-in-Picture toggle to Mode 2 by default. r?Gijs!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1664899 - Make sure the experimental toggle element is hidden when in fullscreen. r?Gijs!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Try push looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5aa27ac017a1bffd7926d970771ae08eeb0400ec

Landing!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4383e6ffea94
Make sure the experimental toggle element is hidden when in fullscreen. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/8c8f6d93ade3
Set the Picture-in-Picture toggle to Mode 2 by default. r=Gijs

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9175616 [details]
Bug 1664899 - Make sure the experimental toggle element is hidden when in fullscreen. r?Gijs!

Beta/Release Uplift Approval Request

• User impact if declined: Users that use the Mode 2 Picture-in-Picture toggle variation (which will be part of the Shirley experiment) will see the new Picture-in-Picture toggle when in DOM fullscreen mode. This is a behavioural regression from the original toggle.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a CSS only change that is really small, well understood, and self-contained.
• String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9175616 [details]
Bug 1664899 - Make sure the experimental toggle element is hidden when in fullscreen. r?Gijs!

Approved for 81.0rc1.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/c6385072fc3c

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4383e6ffea94
https://hg.mozilla.org/mozilla-central/rev/8c8f6d93ade3

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #26941 (as of Tue, 15 Sep 2020 13:29:12 GMT) ==

Improvements:

21% glterrain macosx1014-64-shippable-qr opt e10s stylo 5.43 -> 4.29
3% displaylist_mutate linux64-shippable-qr opt e10s stylo 2,845.00 -> 2,749.70

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26941