Closed Bug 1664899 Opened 3 months ago Closed 3 months ago

Set Mode 2 in the right position as the default Picture-in-Picture toggle

Categories

(Toolkit :: Video/Audio Controls, task)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox81 --- fixed
firefox82 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(2 files)

Data science is in - we believe Mode 2, right position is the winner.

Assignee: nobody → mconley
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4383e6ffea94
Make sure the experimental toggle element is hidden when in fullscreen. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/8c8f6d93ade3
Set the Picture-in-Picture toggle to Mode 2 by default. r=Gijs

Comment on attachment 9175616 [details]
Bug 1664899 - Make sure the experimental toggle element is hidden when in fullscreen. r?Gijs!

Beta/Release Uplift Approval Request

  • User impact if declined: Users that use the Mode 2 Picture-in-Picture toggle variation (which will be part of the Shirley experiment) will see the new Picture-in-Picture toggle when in DOM fullscreen mode. This is a behavioural regression from the original toggle.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a CSS only change that is really small, well understood, and self-contained.
  • String changes made/needed:
Attachment #9175616 - Flags: approval-mozilla-beta?

Comment on attachment 9175616 [details]
Bug 1664899 - Make sure the experimental toggle element is hidden when in fullscreen. r?Gijs!

Approved for 81.0rc1.

Attachment #9175616 - Flags: approval-mozilla-beta? → approval-mozilla-release+
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

== Change summary for alert #26941 (as of Tue, 15 Sep 2020 13:29:12 GMT) ==

Improvements:

21% glterrain macosx1014-64-shippable-qr opt e10s stylo 5.43 -> 4.29
3% displaylist_mutate linux64-shippable-qr opt e10s stylo 2,845.00 -> 2,749.70

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26941

Depends on: 1666561
No longer depends on: 1666561
Regressions: 1666561
Regressions: 1666637
Regressions: 1666775
You need to log in before you can comment on or make changes to this bug.