1666776 - Start print when Enter is pressed when print preview select controls are focused

Status: VERIFIED FIXED

(Toolkit :: Printing, enhancement, P1)

Description

[Jonathan Watt [:jwatt]]

This has irked me, and since I've just noticed a SUMO issue about this I thought I better file it: https://support.mozilla.org/en-US/questions/1302466

Comment 1

[Tom Schuster [:evilpie]]

This is annoying for people who only use a keyboard. From what I can tell you basically have to tab through everything until you arrive at the Print button.

Comment 2

[Jonathan Watt [:jwatt]]

Yeah, let me bump this to P1 to get it on the frontend team's radar and see what they think.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

So, Mark and I have chatted about this, and want to get a little more information from our friendly a11y folks before making this change. I feel like putting focus on the very last thing on the page isn't the right answer here, since <enter> submits the form if you're on most of the other controls, and because it seems like it would be kinda confusing.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role says that "it could be the first field in the form", which is what we're currently doing.

So, I think we're probably going to try and change it so that <enter> always submits the form, but I'll let Mark confirm that.
(And yeah, getting it into 82 would be nice.)

Comment 4

[Jonathan Watt [:jwatt]]

Let's punt this to v83 then? I assume since Jamie hasn't mentioned this as an issue it isn't critical for a11y.

Comment 5

[Mark Striemer [:mstriemer]]

I discussed this with marcoz and yzen in #accessibility on Slack and they were okay with us moving the focus to the Print button instead since you can use F6/Shift+F6 to between the address bar, preview browser and top of the settings browser.

I'll take a look at getting this done today so we can include it in v82.

Comment 6

[Mark Striemer [:mstriemer]]

Attachment: Bug 1666776 - Start print with Enter when select is focused r?jamie,emalysz,gijs

Comment 7

[James Teh [:Jamie]]

(In reply to Mark Striemer [:mstriemer] from comment #5)

I discussed this with marcoz and yzen in #accessibility on Slack and they were okay with us moving the focus to the Print button instead since you can use F6/Shift+F6 to between the address bar, preview browser and top of the settings browser.

While it's true that you can use f6 or shift+f6 to get to the settings, it's definitely not delightful or efficient and potentially quite confusing for less experienced users. This would probably be acceptable in a world where users rarely touch the settings (which is what I think Marco and Yura were thinking), but since PDF printing is done by changing the printer, I don't think this is so true these days. I'd really prefer that we keep initial focus on the printer picker and override enter to submit the form here (but ideally only if the picker isn't expanded, which... I hope we can detect that?).

(As a side note, why does enter on a select do nothing in a form anyway? That doesn't seem useful to me.)

That said, I do understand this is potentially time sensitive, so I guess I can live with this for 82 if the other patch is problematic/harder to write and we want this fixed in 82.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b5fa53e519c
Start print with Enter when select is focused r=Jamie,emalysz

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7b5fa53e519c

Comment 11

[Cornel Ionce [:cornel_ionce], Desktop Release QA]

Confirming that printing is now started when Enter is pressed across platform, using Fx 83.0b2.