1666839 - Windows with titlebar have black background box offset region on Elementary OS

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Luker]

Attachment: bug.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

make sure you update your firefox to 81.0
ope a windows and a tab then unmaximize and see black window behind firefox window

os: elementary os 5.1.7 (linux)
desktop env: GTK 3.22.30
firefox version:81(80 not affected)

Actual results:

black window behind firefox window appear

Expected results:

the black window not apear

Comment 1

[Luker]

[Tracking Requested - why for this release]:

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Kestrel]

I can reproduce this with Firefox windows that have titlebars on Elementary OS 5.1. It is based on Ubuntu 18.04 LTS but I was unable to reproduce it there with the latest 18.04.5 ISO.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7134225dde7d8481a503a10f2ada8c1f038e488e&tochange=16bf991df0003caa9a5db83448373fb4f0bcd561

Regressed by Bug 1617002.

Comment 4

[Luker]

(In reply to Kestrel from comment #3)

I can reproduce this with Firefox windows that have titlebars on Elementary OS 5.1. It is based on Ubuntu 18.04 LTS but I was unable to reproduce it there with the latest 18.04.5 ISO.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7134225dde7d8481a503a10f2ada8c1f038e488e&tochange=16bf991df0003caa9a5db83448373fb4f0bcd561

Regressed by Bug 1617002.

it may affect only elementary os

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This is a bit concerning to me given our shipping WR to some Linux users in Fx84. Any idea what might be happening here, Robert?

Comment 6

[Martin Stránský [:stransky] (ni? me)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

This is a bit concerning to me given our shipping WR to some Linux users in Fx84. Any idea what might be happening here, Robert?

Btw. we ship WR/Fx84 on Gnome only, right?

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Luker, can you please attach output of 'env | grep XDG' terminal command? I think we also don't hide system titlebar by default on Elementary OS due to some issues there.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

(In reply to Martin Stránský [:stransky] from comment #7)

Luker, can you please attach output of 'env | grep XDG' terminal command? I think we also don't hide system titlebar by default on Elementary OS due to some issues there.

Discard that please, I see you have the system titlebar enabled.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

I'll look at it.

Comment 10

[Robert Mader [:rmader]]

Does this by any chance only happen with scaling? Because this pretty much looks like a mutter bug that has long been fixed - but maybe the fix hasn't made it into their version yet.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

No, I can reproduce it without scaling and when system titlebar is on. When system titlebar is disabled it works ok (which is the default state on Elementary).

Comment 12

[Kestrel]

(In reply to Martin Stránský [:stransky] from comment #11)

When system titlebar is disabled it works ok

Not in the case of the Library window (Ctrl+Shift+O) which always uses the system titlebar.

Comment 13

[Martin Stránský [:stransky] (ni? me)]

We need to set correct opaque region coordinates when system titlebar is on and we use CSD. We set opaque region to mShell but at 0,0 coordinates which is wrong as CSD is painted at 0,0.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1666839 [Linux] When we draw to container (CSD mode), shift mShell opaque mask to container position, r?jhorak

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88585daea774
[Linux] When we draw to container (CSD mode), shift mShell opaque mask to container position, r=jhorak

Comment 17

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/88585daea774

Comment 18

[u664683]

Firefox 85.0a1 still shows that box: https://i.stack.imgur.com/ruj91.png plus an additional shadow is displayed under the menu: https://i.stack.imgur.com/nbgFv.jpg

Sorry for posting links like this, didn't find a way to attach images.

Comment 19

[u664683]

Attachment: Screenshot from 2020-12-08 15.53.28.jpeg

oh got it!

Comment 20

[u664683]

Attachment: Screenshot from 2020-12-08 15-45-38.png

here's one more...

can I attach multiples files in one go?

Comment 21

[Martin Stránský [:stransky] (ni? me)]

Okay, will look at it.

Comment 22

[Robert Mader [:rmader]]

Jovial: looks like your build may not yet include the fix - maybe you just need to wait till tomorrow :)

Comment 23

[u664683]

No, problem :) Thanks for the update!

Comment 24

[u664683]

(In reply to jovial7joe from comment #23)

No, problem :) Thanks for the update!

and the fix!

Comment 25

[Luker]

thank you fix the issue, hope fix in other ones

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Is this something you'd want to nominate for an RC2 ride-along, Martin?

Comment 27

[Martin Stránský [:stransky] (ni? me)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #26)

Is this something you'd want to nominate for an RC2 ride-along, Martin?

I'd love so but I'm unsure of possible regressions here due to changed positioning mechanism. Better to keep it in beta.

Comment 28

[Kestrel]

(In reply to jovial7joe from comment #18)

plus an additional shadow is displayed under the menu

That's Bug 1674473.