1666923 - fission.sessionHistoryInParent set to true breaks Picture-in-Picture

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Danny Colin [:sdk]]

Attachment: fission-history-pip-2020-09-23_17.18.04.mkv

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

0. Set fission.sessionHistoryInParent to true
1. Restart the browser
2. Go to youtube (e.g https://www.youtube.com/watch?v=JDUnSsx62j8)
3. Toggle Picture-in-Picture (either with the button or the keyboard shortcut)

Actual results:

Picture-in-Picture shows an empty window. Also, trying to close the Picture-in-Picture window doesn't work with the keyboard shortcut. The flickering of the window happens when you trigger the shortcut. You have to click on the close button of the PiP window.

Expected results:

The video should be moved to the PiP window and you should still be able to close the PiP window with the keyboard shortcut.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1666923 - fission.sessionHistoryInParent set to true breaks Picture-in-Picture

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

That wip patch isn't correct one, but might make sense anyhow (and perhaps should land if the real fix for this takes a bit time).

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a54ee38496d0fdec23001add10d1dfcb52007b6

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81f66369d5a7
fission.sessionHistoryInParent set to true breaks Picture-in-Picture r=mconley

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/81f66369d5a7