1667025 - Options in End-to-End Encryption in Manage Identities are not saved

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Martin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36

Steps to reproduce:

Opened any of my alternate identities of an account in Account Settings -> Manage Identities and there under End-to-End Encryption I changed some settings like "Add my digital signature by default" and "Preferred encryption technology". Then clicked "Ok" for saving the changes. I get back to the list of identities.

Actual results:

The changes are not saved.

Expected results:

Saved changes. ;-)

Comment 1

[Magnus Melin [:mkmelin]]

Confirmed. Khushil, please take a look.

Comment 2

[Khushil Mistry [:khushil324]]

Attachment: Bug-1667025_e2e-manage-indetities-not-saving-0.patch

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9178978 [details] [diff] [review]
Bug-1667025_e2e-manage-indetities-not-saving-0.patch

Review of attachment 9178978 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I assume this never worked in 78.

Comment 4

[Khushil Mistry [:khushil324]]

Yes, we need beta uplift as well as ESR uplift.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a85aeb24984a
Fix options in End-to-End Encryption in Manage Identities are not saved. r=mkmelin DONTBUILD

Comment 6

[Khushil Mistry [:khushil324]]

Comment on attachment 9178978 [details] [diff] [review]
Bug-1667025_e2e-manage-indetities-not-saving-0.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 1610445
User impact if declined: Encryption setting in manage identities will not be saved.
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): Low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9178978 [details] [diff] [review]
Bug-1667025_e2e-manage-indetities-not-saving-0.patch

[Triage Comment]
Approved for esr78
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.3.2:
https://hg.mozilla.org/releases/comm-esr78/rev/c7db982d4c67

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/cb849b6e0f68