If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Alt+tabbing to another app & back can disable typeaheadfind

VERIFIED FIXED in mozilla1.1alpha

Status

SeaMonkey
Find In Page
P1
normal
VERIFIED FIXED
15 years ago
9 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

Trunk
mozilla1.1alpha
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

15 years ago
If you use Alt+Tab, but let go of the alt before the tab, typeaheadfind gets
disabled.

This is because typeaheadfind receives a DOMMenuBarActive event, but not a
DOMMenuBarInactive event. It turns out that ToggleMenuActiveState() uses
SetActive(PR_TRUE) to turn on menus, but it doesn't use SetActive(PR_FALSE) to
turn them off. SetActive is where the DOMMenuBar* events are fired.

This occurs on Windows, possibly on Linux.
(Assignee)

Updated

15 years ago
Blocks: 30088
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.1alpha
(Assignee)

Comment 1

15 years ago
Created attachment 97855 [details] [diff] [review]
Patches nsMenuBarFrame.cpp, changes ToggleMenuActiveState()

Should get review from hyatt, he's the only one who's touched this code.
Otherwise, please tell me who should review it now.

Comment 2

15 years ago
i'm not sure which bug tracks it. but after i copy from browser and paste into
mailnews composer i can't actually type letters into it. I have to alt-tab back
to navigator, press a key and alt-tab back to mailnews composer. (w32 2002090408)
Summary: Alt+tabbing to anoither app & back can disable typeaheadfind → Alt+tabbing to another app & back can disable typeaheadfind
(Assignee)

Comment 3

15 years ago
Timeless, I can't dup that bug. It's different than this bug anyway. You can
file a new bug if you like. Could you include more details of the behavior -
does it start searching for what you type while you're in mailcompose? Does the
status bar say anything?

Comment 4

15 years ago
Comment on attachment 97855 [details] [diff] [review]
Patches nsMenuBarFrame.cpp, changes ToggleMenuActiveState()

looks good to me. there is one nit: seems InstallKeyboardNavigator() was called
twice. could you fix this too?
(Assignee)

Comment 5

15 years ago
Created attachment 97910 [details] [diff] [review]
Gets rid of unneeded call to InstallKeyboardNavigator(), and fixes comment to say we use the menuactive attribute

Seeking r=

Comment 6

15 years ago
Comment on attachment 97910 [details] [diff] [review]
Gets rid of unneeded call to InstallKeyboardNavigator(), and fixes comment to say we use the menuactive attribute

r=kyle
Attachment #97910 - Flags: review+

Comment 7

15 years ago
fwiw my concern was bug 166955 which has been fixed
(Assignee)

Comment 8

15 years ago
Kyle, could you test this on Linux or Solaris for me, and make sure that we
never lose the caret when Alt+Tabbing or using the menubar, and that everything
related to the menubar still works?
(Assignee)

Comment 9

15 years ago
Created attachment 98068 [details]
Annotated patch describing each change
(Assignee)

Comment 10

15 years ago
I tried all kinds of things on Windows, and couldn't see any difference. No
surprises there. Kyle is testing on Unix.

Also have the annotated patch describing each change attached to this bug.
Comment on attachment 97910 [details] [diff] [review]
Gets rid of unneeded call to InstallKeyboardNavigator(), and fixes comment to say we use the menuactive attribute

sr=jst
Attachment #97910 - Flags: superreview+
(Assignee)

Comment 12

15 years ago
Asa gave a= on IRC

Comment 13

15 years ago
tested this patch on Solaris, it works fine. 

aaron, some sr may dislike to put 1-line |if|/|else| bodies into a {} block (in 
SetActive()).
(Assignee)

Comment 14

15 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
looks fixed on win2k and linux rh7.2, 2002.09.24.08 mozilla trunk.
Status: RESOLVED → VERIFIED

Updated

15 years ago
Component: Keyboard: Navigation → Keyboard: Find as you Type
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.