1667041 - Do not consume all cores when indexing C++ with clangd

Status: RESOLVED FIXED

(Developer Infrastructure :: Developer Environment Integration, enhancement)

Description

[Andi [:andi]]

When using clangd with vscode we shouldn't consume all available cores for indexing TU and it's includes, a better approach would be to consume only half of them.

Comment 1

[Andi [:andi]]

Attachment: Bug 1667041 - Do not consume all cores when indexing C++ with `clangd` from `vscode`. r=sylvestre

Comment 2

[Mike Hommey [:glandium]]

(In reply to Andi-Bogdan Postelnicu [:andi] from comment #0)

When using clangd with vscode we shouldn't consume all available cores for indexing TU and it's includes, a better approach would be to consume only half of them.

Why? clangd sets itself to have a low priority.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

I tried this morning to open js/src/vm/Runtime.h with clangd and it uses all CPU to the point that spotify wasn't playing music anymore :p

Maybe changing the priority could be enough?

Comment 4

[Andi [:andi]]

It's the same on windows, let's make this more conventional and use less cpu cores.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07835afc964c
Do not consume all cores when indexing C++ with `clangd` from `vscode`. r=sylvestre

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/07835afc964c