1667109 - Small tweaks for the Windows input fields

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

The input fields on Windows are a bit too narrow: the cursor touches the top and bottom border. Also the spin-buttons aren't correctly centred: on top 1px gap and on bottom/end no gap to the border.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1667109-input-spacing.patch

This fixes the issues. I checked other fields and they don't regress. A comparison screenshot follows for easier review.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: comparison.png

On the left before patch and on the right with patch.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9177642 [details] [diff] [review]
1667109-input-spacing.patch

Review of attachment 9177642 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a31518ad1c96
Windows: tune the inputfield spacings. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9177642 [details] [diff] [review]
1667109-input-spacing.patch

[Approval Request Comment]
User impact if declined: no real impact, only a visual improvement
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, only small size changes

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9177642 [details] [diff] [review]
1667109-input-spacing.patch

[Triage Comment]
Approved for esr78 (cosmetic, so not requiring beta)
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 82.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/1e5b243d6a1d

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.3.2:
https://hg.mozilla.org/releases/comm-esr78/rev/4b54cd82bb03