1667121 - CBCS incorrectly configured as CENC when sending video decoder init to CDM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Bug 1654397 incorrectly sets the crypto scheme when using CBCS to CENC, this typo should be fixed.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1667121 - Set Cbcs encryption scheme correctly when initializing CDM. r?alwu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fed5816432cb
Set Cbcs encryption scheme correctly when initializing CDM. r=alwu

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fed5816432cb

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1654397

Comment 5

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9177649 [details]
Bug 1667121 - Set Cbcs encryption scheme correctly when initializing CDM. r?alwu

Beta/Release Uplift Approval Request

• User impact if declined: Possible bustages with sites playing encrypted media. The CDM is a black box and it's not 100% clear how it will respond to misconfiguration across different inputs so I'd rather we pass the correct config to be safe.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's low risk as it's a single line change that fixing a typo.
• String changes made/needed: None.

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9177649 [details]
Bug 1667121 - Set Cbcs encryption scheme correctly when initializing CDM. r?alwu

regression fix, approved for 82.0b4

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4ff8238f62e9