1667176 - Start cleaning up layers logging code

Status: RESOLVED FIXED

(Core :: Graphics: Layers, task, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

I started on some patches for bug 1666802, but haven't done it all yet. I want to land them incrementally rather than have a 100-patch series so I'm spinning out sub-bugs as I go.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=91af35d504a3183b3c06db63990b96ac802daa34

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667176 - Miscellaneous unified build fixes. r?mattwoodrow

Upcoming patches shift around which files get unified and expose these build
failures.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667176 - Move ScrollableLayerGuid functions into a .cpp file. r?mattwoodrow

Depends on D91332

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667176 - Collapse ScrollableLayerGuid stringification functions. r?mattwoodrow

Depends on D91333

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667176 - Remove the void* AppendToString function, and fix the typo that exposed. r?mattwoodrow

Depends on D91334

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667176 - Remove the ViewID AppendToString function, and convert call sites to stream writes. r?mattwoodrow

Depends on D91335

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667176 - Remove unused sRGBColor AppendToString function. r?mattwoodrow

Depends on D91336

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667176 - Replace AppendToString for DeviceColor with ostream operator. r?mattwoodrow

Depends on D91337

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667176 - Use ostream operator instead of AppendToString for nsPoint. r?mattwoodrow

Depends on D91338

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667176 - Use ostream operator instead of AppendToString for nsRect. r?mattwoodrow

Depends on D91339

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667176 - Use ostream operator instead of AppendToString for nsRectAbsolute. r?mattwoodrow

Depends on D91340

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/748a1bdc27c1
Miscellaneous unified build fixes. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/a5cf7b49d17f
Move ScrollableLayerGuid functions into a .cpp file. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/bad3de147b6b
Collapse ScrollableLayerGuid stringification functions. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/df3d474c3a91
Remove the void* AppendToString function, and fix the typo that exposed. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/8154aba88237
Remove the ViewID AppendToString function, and convert call sites to stream writes. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/8689146f4d04
Remove unused sRGBColor AppendToString function. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/8a101a1e048b
Replace AppendToString for DeviceColor with ostream operator. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/30d353e489af
Use ostream operator instead of AppendToString for nsPoint. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/24f512e00876
Use ostream operator instead of AppendToString for nsRect. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/2065d62cfbb5
Use ostream operator instead of AppendToString for nsRectAbsolute. r=mattwoodrow

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667176 - Follow-up to allow apz_test_utils to parse the new stringified rect format.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43e3a7215f9b
Follow-up to allow apz_test_utils to parse the new stringified rect format. r=botond

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62baa60811ef
Fix lint error on apz_test_utils.js a=lint-fix DONTBUILD

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/748a1bdc27c1
https://hg.mozilla.org/mozilla-central/rev/a5cf7b49d17f
https://hg.mozilla.org/mozilla-central/rev/bad3de147b6b
https://hg.mozilla.org/mozilla-central/rev/df3d474c3a91
https://hg.mozilla.org/mozilla-central/rev/8154aba88237
https://hg.mozilla.org/mozilla-central/rev/8689146f4d04
https://hg.mozilla.org/mozilla-central/rev/8a101a1e048b
https://hg.mozilla.org/mozilla-central/rev/30d353e489af
https://hg.mozilla.org/mozilla-central/rev/24f512e00876
https://hg.mozilla.org/mozilla-central/rev/2065d62cfbb5
https://hg.mozilla.org/mozilla-central/rev/43e3a7215f9b
https://hg.mozilla.org/mozilla-central/rev/62baa60811ef

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Turns out removing the nsRect variant of AppendToString caused many of the calls to Stringify(nsRect) go through Stringify(nsRegion(nsRect)) instead because nsRegion has an implicit constructor for nsRect. Sadness. But I'll fix it when I get rid of the Stringify(nsRegion) variant.