1667233 - |/api/feed.for_email.query| Too many transactions match type

Status: RESOLVED FIXED

(Conduit :: Phabricator, defect)

Description

[Mitchell Hentges [:mhentges] 🦀]

See this Sentry ticket

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

This issue is triggered because:

• An assumption was made that if a user changed the reviewers of a patch, that "story" would only have, at most, a single "reviewer change" transaction
• If a user has a herald rule, transactions made by that herald rule are part of the same "story" triggered by the user
• If a user and their herald rule changes the reviewers of a patch, those two "reviewer-change" transactions are not combined

Here's (one of) the cases triggering this error. The tgiles and Herald reviewer changes are both different transactions under the same "story".

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1667233: Don't throw exception if herald adds reviewer

It's possible for a single story to have two separate reviewer
transactions: a herald rule to add a reviewer must be triggered by a
different revewer being added. In this case, gracefully handle the
separate reviewer transactions.