1667294 - TB E10s goal 1: get a webpage loading in the message pane

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan)]

I'm trying to do the most basic thing an E10s-enabled Thunderbird should be able to do – load a web page.

The aim is to start the program, open the devtools, and run this without crashing:

document.getElementById("messagepane").loadURI("https://www.example.com/")

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1667294 - Allow loading of web pages in remote browsers. r?mkmelin

Comment 2

[Geoff Lankow (:darktrojan)]

From bug 1646648 comment 3:

Current status: I'm trying to get a page to load in the message pane, but it crashes. I've traced the problem back to here – I don't know why the pipe is closed, or even what pipe we're talking about. There's also a problem here where sharedData doesn't have a lot of the things I expect it should have, including ChildSingletonActors. This could be related to the first problem, I don't know.

Comment 3

[Geoff Lankow (:darktrojan)]

I'm not sure if it helps any, but these are the processes that run (paths shortened for readability):

1149489 objdir/dist/bin/thunderbird --purgecaches -no-remote -profile objdir/tmp/profile-default
1149595 objdir/dist/bin/thunderbird -contentproc -childID 1 -isForBrowser -prefsLen 1 -prefMapSize 223621 -parentBuildID 20200925140353 -appdir objdir/dist/bin 1149489 false tab
1149685 objdir/dist/bin/thunderbird -contentproc -childID 2 -isForBrowser -prefsLen 1470 -prefMapSize 223621 -parentBuildID 20200925140353 -appdir objdir/dist/bin 1149489 false tab

-prefsLen 1 seems a bit wrong.

Comment 4

[Geoff Lankow (:darktrojan)]

CC'ing the IPC module folks in the hope they can help.

Comment 5

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

That case in ipc_channel_posix.cc handles end-of-file on the socketpair underlying the channel. Typically that means the other process crashed, but for a channel opened by passing an Endpoint object (rather than a child process's initial channel) it could be the result of the Endpoint being dropped in some error case. But I don't know how that would connect to any high-level things that TB might be doing / not doing.

Nika, do you have any insight about this from the DOM side?

Comment 6

[Geoff Lankow (:darktrojan)]

Perhaps what I'm looking at isn't the initial problem but a symptom, and something happens earlier causing a crash.

Comment 7

[alta88]

1. Is "messgepane" hardcoded anywhere for different treatment.
2. Does anything work in a content tab <browser> (not a messagepane).

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Yeah, I'm guessing the content process is aborting early during startup for some reason, which could lead to an error being produced in that code. Perhaps try recording the execution under rr to see what's happening in the content process.

Comment 9

[Geoff Lankow (:darktrojan)]

I have succeeded! Things were starting up in the child process that shouldn't have been, and this was causing assertion failures.

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1667294 - Skip parts of SandboxBroker::LaunchApp when launching a Thunderbird process. r?tkikuchi

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d16e9465118
Skip parts of SandboxBroker::LaunchApp when launching a Thunderbird process. r=tkikuchi

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3d16e9465118

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fb0e4da49a0b
Allow loading of web pages in remote browsers. r=mkmelin