1667317 - Dark mode: OpenPGP indicators in status bar of mail compose window barely visible

Status: VERIFIED FIXED

(Thunderbird :: Theme, defect)

Description

[Andreas]

Attachment: OpenPGP status.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36 Edg/85.0.564.51

Steps to reproduce:

Have dark mode enabled. Open the mail compose window. Select "require encryption" in the options menu.

Actual results:

There is an OpenPGP status indicator in the status bar, but the icons are barely visible. The signature icon is not centered between its borders.

Expected results:

Change the icons to follow the theme settings. You could also switch their order to be consistent with the message header pane (lock left, signature right).
As I understand, bug 1667254 will improve this implementation in the long term (Post-78?). But it would be nice to fix the colors in the short term.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1667317-status-icon-use-currentcolor.patch

Let the icons use the currentColor fill.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9177837 [details] [diff] [review]
1667317-status-icon-use-currentcolor.patch

Review of attachment 9177837 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, I totally missed that, thanks!

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1667317-status-icon-use-currentcolor.patch

I found an icon which was only defined under Linux.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9177911 [details] [diff] [review]
1667317-status-icon-use-currentcolor.patch

Review of attachment 9177911 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for catching my errors :D

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fca34d6b372a
Let the OpenPGP and S/MIME status icons adapt on dark theme. r=aleca DONTBUILD

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9177911 [details] [diff] [review]
1667317-status-icon-use-currentcolor.patch

[Approval Request Comment]
Regression caused by (bug #): some PGP bug
User impact if declined: invisible status icons with dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, needs bug 1647039 applied first.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9177911 [details] [diff] [review]
1667317-status-icon-use-currentcolor.patch

[Triage Comment]
Approved for esr78
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 82.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b891827a4336

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.3.2:
https://hg.mozilla.org/releases/comm-esr78/rev/a7741b74b1ea

Comment 10

[Ramona Gavrilescu]

Confirming this issue as verified fixed for 128.0esr(220240703144221) on macOS Sonoma 14 and Win 11