1667341 - Move isDevToolsExtensionContext from the target to the descriptor

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

See comment thread at https://phabricator.services.mozilla.com/D91106#inline-517310

The flag isDevToolsExtensionContext is currently set on the BrowsingContextTarget. We could set it in the descriptor instead since it's only related to how we handle the TabRemotenessChange event, which is handled by the TabDescriptor now.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1667341 - [devtools] Move isDevToolsExtensionContext from the target to the descriptor

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1667341 - [devtools] Return a descriptor from createTargetForTab

Depends on D91563

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jdescottes, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87025d0359a6
[devtools] Move isDevToolsExtensionContext from the target to the descriptor r=ochameau,rpl
https://hg.mozilla.org/integration/autoland/rev/505cffa82c83
[devtools] Return a descriptor from createTargetForTab r=ochameau

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/87025d0359a6
https://hg.mozilla.org/mozilla-central/rev/505cffa82c83