166746 - prefill "name" after accessing "bookmark this link" for linked image

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect, P3)

Description

[sairuh (rarely reading bugmail)]

tested using 2002.09.04.05. unlike "bookmark this page" (page context menu) and
"bookmark this link" (regular text link context menu), the "Name" field for the
bookmark sheet isn't prefilled for "bookmark this link" for a linked image.

why not prefill it (and select/highlight it as in the other cases) with
something like the link's target url?

1. go to a page with a linked image. eg, the banner at the top of this page, or
the "wired news" logo in the upper-left of http://wired.com/news/nc_index.html

2. bring up the context menu for the linked image, and select "bookmark this link"

3. observe the resulting bookmark sheet.

results: focus is in the "Name" field (which is good), but it's empty.

Comment 1

[Lou Brothers]

Recommend using the ALT attribute's value for the bookmark name - failing its 
existence the URL should be used.

Comment 2

[sairuh (rarely reading bugmail)]

since it's bookmarking the link, why not use the anchor's TITLE value, if
provided? (if not, then fall back on the url.)

Comment 3

[Greg K.]

See also bug 163709.

Comment 4

[Jasper]

Simon wouldn't this be an easy fix as you just fixed bug 281133?

Comment 5

[Simon Fraser [no longer active]]

Yeah, putting the url in there should be easy.

Comment 6

[Simon Fraser [no longer active]]

Attachment: Testcase

Comment 7

[Simon Fraser [no longer active]]

Fixed to use the url if there is no title.