1667471 - Expose a way to filter headers in loadUri

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Filtering headers for loadUri requests is error-prone and shouldn't be left to every app to implement.

We can provider some common filters that the embedder can use like CORS safelisted as argument.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1667471 - Expose IsCORSSafelistedRequestHeader in WindowUtils.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1667471 - Add builder-like replacement for loadUri.

This introduces a new way of loading URIs in GeckoSession, using a builder-like
method loader() which deprecates the existing loadUri.

This change improves readability of long loadUri calls and allows us to add
more parameters without compromising usability.

It also fixes a bug where we were not short-circuiting the onLoadRequest call
in some cases.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1667471 - Add header filter to GeckoSession.loader.

This allows apps to modify the header filtering behavior, and introduces a safe
default (CORS safelisted).

Deprecated loadUri methods still maintain the old behavior so that we don't
inadvertently introduce bugs in apps.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1453c6199311
Expose IsCORSSafelistedRequestHeader in WindowUtils. r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/f7642b4cb27a
Add builder-like replacement for loadUri. r=snorp,owlish
https://hg.mozilla.org/integration/autoland/rev/ab5779c59cca
Add header filter to GeckoSession.loader. r=snorp,esawin

Comment 5

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Copt%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-junit-e10s%2Cgv-junit&revision=ab5779c59cca46fb0da9ffbac07c7c6662abeb1c&selectedTaskRun=IK4adlQdTISEKf2XvZmP_w.0

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318650403&repo=autoland&lineNumber=8226

Backout: https://hg.mozilla.org/integration/autoland/rev/c897033e4e0ee282d6cc857ed00e1f13d54cfbc9

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad8b66ec5171
Expose IsCORSSafelistedRequestHeader in WindowUtils. r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/fdc015927934
Add builder-like replacement for loadUri. r=snorp,owlish
https://hg.mozilla.org/integration/autoland/rev/cfd11957a8a0
Add header filter to GeckoSession.loader. r=snorp,esawin

Comment 7

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=CSRW9N1rTsOg4Nq9kVHFHw.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Copt%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-junit-e10s%2Cgv-junit&revision=cfd11957a8a08d71d6be1f29f9b022ad44d9e019

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318663508&repo=autoland&lineNumber=8232

Backout: https://hg.mozilla.org/integration/autoland/rev/808b9d6e2bab8a4f726c881278f6358e8b27185a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da7218c3e911
Expose IsCORSSafelistedRequestHeader in WindowUtils. r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/e607433d5ec5
Add builder-like replacement for loadUri. r=snorp,owlish
https://hg.mozilla.org/integration/autoland/rev/ec225bf5041b
Add header filter to GeckoSession.loader. r=snorp,esawin

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/da7218c3e911
https://hg.mozilla.org/mozilla-central/rev/e607433d5ec5
https://hg.mozilla.org/mozilla-central/rev/ec225bf5041b

Comment 10

[[ex-Mozilla] Agi Sferro | :agi]

Thanks!