1667848 - [wpt-sync] Sync PR 25821 - content-visibility: Ensure to keep the DL unlocked if targetted by scroll

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 25821 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25821
Details from upstream follow.

b'Vladimir Levin <[e-mail]>' wrote:

content-visibility: Ensure to keep the DL unlocked if targetted by scroll

This patch generalizes the find-in-page fix we had previously to also
apply to other methods that can use to scroll the viewport to the
element in a locked subtree. Specifically, this keep the lock unlocked
for two frames to ensure that the visibility notification kicks in to
keep it unlocked until the user scrolls away.

R=[e-mail]

Bug: 1132869
Change-Id: I598f82f73429e41839a6675321eb6fb1eb84f6b5
Reviewed-on: https://chromium-review.googlesource.com/2435808
WPT-Export-Revision: f3d2c3dd16d465b612ee6db4056727e2b63bdb96

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=be09dd33ea1da2543dbf127a3da6f20ea9d3075d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

OK : 1
FAIL: 7

Chrome

OK : 1
PASS: 4
FAIL: 3

Safari

OK : 1
PASS: 2
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-contain/content-visibility/content-visibility-026.html
content-visibility: hidden adds contain: size layout style;: FAIL (Chrome: PASS, Safari: FAIL)
content-visibility: auto adds contain: size layout style paint;: FAIL (Chrome: PASS, Safari: FAIL)
content-visibility: auto adds contain: size layout style paint, can't be overridden: FAIL (Chrome: PASS, Safari: FAIL)
content-visibility keeps all containment even when shorthands are specified: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-contain/content-visibility/content-visibility-058.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/content-visibility/content-visibility-075.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-contain/content-visibility/content-visibility-076.html: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8d8a39bb4db
[wpt PR 25821] - content-visibility: Ensure to keep the DL unlocked if targeted by scroll, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e873b401711c
[wpt PR 25821] - Update wpt metadata, a=testonly

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c8d8a39bb4db
https://hg.mozilla.org/mozilla-central/rev/e873b401711c