Closed Bug 1668136 Opened 4 years ago Closed 11 months ago

New wpt failures in /css/css-contain/content-visibility/ [content-visibility-075.html, content-visibility-076.html]

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox121 --- fixed

People

(Reporter: wpt-sync, Assigned: cathiechen)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [wpt], [wptsync upstream])

Attachments

(1 file)

Bug 1668136 - Set visible the content relevancy of an element with content-visibility:auto if its descendant is called scrollIntoView, r?emilio,dholbert
48 bytes, text/x-phabricator-request
Details | Review

Syncing wpt PR 25821 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

/css/css-contain/content-visibility/content-visibility-075.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-contain/content-visibility/content-visibility-076.html: FAIL (Chrome: FAIL, Safari: PASS)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1667848 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

We fail these tests b/c we don't support the content-visibility property.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE

Reopening; we now have content-visibility preffed on in Nightly, but we still fail these two tests in particular (and a few others).

wpt.fyi links:
https://wpt.fyi/results/css/css-contain/content-visibility/content-visibility-075.html
https://wpt.fyi/results/css/css-contain/content-visibility/content-visibility-076.html

At least for the first one (content-visibility-075.html), it looks like the content area is fine (the screenshot shows "PASS"), and our failure is related to the length of the scroll track. So I think this might just be a version of bug 1820266.

For the second one (content-visibility-076.html), the reftest screenshot is blank for the testcase (aside from the scrollbar), so something else is going on there. Though when I load the test directly, I do see "PASS", so it might just be some sort of timing issue.

Blocks: interop-2023-contain
Status: RESOLVED → REOPENED
Depends on: css-content-visibility
No longer duplicate of bug: css-content-visibility
Resolution: DUPLICATE → ---
See Also: → 1820266

(In reply to Daniel Holbert [:dholbert] from comment #2)

Reopening; we now have content-visibility preffed on in Nightly, but we still fail these two tests in particular (and a few others).

--> Changing the dependency relationship so that this blocks the metabug, rather than being blocked-by (and hoped-to-be-fixed-by) the metabug.

Blocks: css-content-visibility
No longer depends on: css-content-visibility
Assignee: nobody → cathiechen

(In reply to Daniel Holbert [:dholbert] from comment #2)

For the second one (content-visibility-076.html), the reftest screenshot is blank for the testcase (aside from the scrollbar), so something else is going on there. Though when I load the test directly, I do see "PASS", so it might just be some sort of timing issue.

Surprisingly (to me) that the reason why "PASS" doesn't appear in the scrollport is because of bug 1856088, a scroll anchoring issue. With the fix for bug 1856088, "PASS" is reliably appeared there but the vertical scroll thumb position is sometimes incorrect. I mean, the fix for bug 1856088 changes the failure from perma to intermittent. See this try run for example.

I am going to annotate the test as intermittent in bug 1856088. Hope it would help fixing this bug!

Depends on: 1856088
Pushed by surkov.alexander@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/aa66fda02aac
Set visible the content relevancy of an element with content-visibility:auto if its descendant is called scrollIntoView, r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42859 for changes under testing/web-platform/tests
Whiteboard: [wpt] → [wpt], [wptsync upstream]
Regressions: 1862119
Upstream PR was closed without merging
Pushed by zsun@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/6e5782df6da1
Set visible the content relevancy of an element with content-visibility:auto if its descendant is called scrollIntoView, r=emilio
Flags: needinfo?(cathiechen)
Regressions: 1862447

Backed out for causing wpt failures on content-visibility-vs-scrollIntoView-003.html

Backout link

Push with failures

Failure log

This is another fail: https://treeherder.mozilla.org/logviewer?job_id=434600029&repo=autoland&lineNumber=13889

Flags: needinfo?(cathiechen)
Upstream PR was closed without merging

Let me update the expected files

Flags: needinfo?(cathiechen)
Pushed by zsun@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/5aed3b74c9e3
Set visible the content relevancy of an element with content-visibility:auto if its descendant is called scrollIntoView, r=emilio

https://hg.mozilla.org/mozilla-central/rev/5aed3b74c9e3

Status: REOPENED → RESOLVED
Closed: 4 years ago → 11 months ago
status-firefox121: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Upstream PR merged by moz-wptsync-bot
Regressions: 1865267
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: