1667953 - Save to PDF actually prints on macOS (stop propagating unprefixed print.print_to_file=false)

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Emir Marincic]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

1. Open any page
2. Do File->Print
3. Chose "Save to PDF" as the printer and save

Actual results:

An empty file with the chosen name is created and the print job is queued on the default printer.

Expected results:

A PDF file with the contents of the page should be created, no real print job should be queued.

Comment 1

[Pascal Chevrel:pascalc]

[Tracking Requested - why for this release]: Regression maybe caused by the print preview modernization work targeting 82

Comment 2

[Sean Voisen (:svoisen)]

I'm able to reproduce this (tried printing this bug page as an example).

Comment 3

[Jonathan Watt [:jwatt]]

I've managed to reproduce the issue where the "Save to PDF" printer prints to my default physical printer. If the "global" pref print.print_to_file is set to false, then when I first print to the "Save to PDF" printer its nsIPrintSettings object picks up that value and causes the print to go to the wrong place. Worse still, I then end up with the pref print.printer_Mozilla_Save_to_PDF.print_to_file also set to false after that first print to the "Save to PDF" printer. That means that if I remove the "global" pref print.print_to_file I still have the misbehavior. I have to remove both print.print_to_file and print.printer_Mozilla_Save_to_PDF.print_to_file to fix things.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: Bug 1667953 p1. Stop reading printer specific settings from global prefs. r=bobowen

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0f3cbdf8ac5
p1. Stop reading printer specific settings from global prefs. r=bobowen

Comment 6

[Jonathan Watt [:jwatt]]

The part 1 patch will stop this happening to anyone using Nightly/Beta who hasn't already been bitten by this yet. But it won't fix up their prefs for those users that have been. The reason for that is because the frontend code calls initPrintSettingsFromPrefs after it sets printToFile = true:

https://searchfox.org/mozilla-central/source/toolkit/components/printing/content/print.js#893,898,903-907

We don't have nearly enough Beta users as it is, so I think we should really try to fix this up for the users we do have.

Comment 7

[Jonathan Watt [:jwatt]]

Attachment: Bug 1667953 p2. Fixup corrupted 'Save to PDF' printing pref for affected users. r=emalysz,mstriemer

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6eee16ef0575
p2. Fixup corrupted 'Save to PDF' printing pref for affected users. r=emalysz

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c0f3cbdf8ac5

Comment 10

[Jonathan Watt [:jwatt]]

Comment on attachment 9178563 [details]
Bug 1667953 p1. Stop reading printer specific settings from global prefs. r=bobowen

Beta/Release Uplift Approval Request

• User impact if declined: Some users may have 'Save as PDF' in the new UI send a print job to a physical printer instead.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This should only affect users with corrupt prefs.
• String changes made/needed:

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6eee16ef0575

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9178563 [details]
Bug 1667953 p1. Stop reading printer specific settings from global prefs. r=bobowen

approved for 82.0b6

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cdaa313c03cb
https://hg.mozilla.org/releases/mozilla-beta/rev/578deef6fc0a

Comment 14

[Cristian Fogel [:cfogel]]

Verified with 83.0a1 (2020-10-01) and 82.0b6 on macOS 11.0

Comment 15

[Jonathan Watt [:jwatt]]

I used mozregression to track down when we started propagating print.print_to_file onto the print.printer_Mozilla_Save_to_PDF.print_to_file when it's not yet set:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=12349b0246f2a1185dd489e0b1972bffdfe0d93d&tochange=694c9984be24689bd9dcdad5e02a9100fcc7a54d

So this was caused by bug 1663669.

Comment 16

[Jonathan Watt [:jwatt]]

In the Phabricator revision for the first patch I made the following comment for the change to nsPrintSettingsService::InitPrintSettingsFromPrefs which makes InitPrintSettingsFromPrefs no longer read certain unprefixed prefs:

This list is made to match the prefs we currently set in all.js, minus
the unwritable margins which don't seem safe to even include. So
this list specifically excludes:

kInitSaveUnwriteableMargins
kInitSaveOddEvenPages
kInitSaveBGColors
kInitSaveBGImages
kInitSavePaperSize
kInitSaveResolution
kInitSaveDuplex
kInitSaveOrientation
kInitSavePrinterName
kInitSavePrintToFile
kInitSaveToFileName
kInitSavePageDelay
kInitSaveMargins
kInitSaveNativeData
kInitSaveShrinkToFit
kInitSaveScaling

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1667953 - Restore read from global print settings for a few settings, including print_bgcolor and print_bgimages. r=jwatt

These were lost in bug 1667953, but I don't think print_bgimages /
print_bgcolor should be printer-specific only.

Comment 18

[Phabricator Automation]

Comment on attachment 9203699 [details]
Bug 1667953 - Restore read from global print settings for a few settings, including print_bgcolor and print_bgimages. r=jwatt

Revision D105465 was moved to bug 1692845. Setting attachment 9203699 [details] to obsolete.