1669922 - Scale options are no longer working inside the old UI

Status: RESOLVED DUPLICATE of bug 1669187

(Core :: Print Preview, defect)

Description

[Anca Soncutean, Desktop QA]

Attachment: screencast issue.gif

Affected versions

• 83.0a1 (2020-10-07)
• 82.0b8

Affected platforms

• Windows 10
• Windows 7
• Ubuntu 18.04

Unaffected platforms

• macOS 10.15.7

Steps to reproduce

1. Launch Firefox
2. Make sure print.tab-modal.enabled is set on false
3. Open any page
4. Open Print preview
5. Choose any scale except 100% and Shrink to fit

Expected result

• The scale options can be applied, the print preview content is adjusted accordingly

Actual result

• Only Shrink to fit and 100% can be set as scale options

Regression range

• First bad: 480b4aeecc2bfab12d2c5b86e21542e76c0ddb62 (2020-09-30)
• Last good: d286def58a48e3ee5f9420998022bc13e0124191 (2020-09-29)
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d286def58a48e3ee5f9420998022bc13e0124191&tochange=480b4aeecc2bfab12d2c5b86e21542e76c0ddb62

Additional notes

• Not reproducible with the new UI
• If save to pdf or actual printing is done previously with the new UI, than going to the old one, the issue is no longer reproducible (but only setting print.tab-modal.enabled to true doesn't make any difference)

Suggested severity

• S2

Comment 1

[Anca Soncutean, Desktop QA]

Actually the issue is fixed after the first print is done from the old UI. Looks like this is closely linked to 1669187 and/or 1668621.

Comment 2

[Bob Owen (:bobowen)]

(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #1)

Actually the issue is fixed after the first print is done from the old UI. Looks like this is closely linked to 1669187 and/or 1668621.

Just about to ask that question. :-)
Yes pretty sure this is the same root cause then.

Comment 3

[Bob Owen (:bobowen)]

Should be fixed in bug 1669187.

Comment 4

[Jonathan Watt [:jwatt]]

Yeah, the patch for bug 1669187 fixes this, at least to the extent we can without taking on too much risk. I'm just going to mark this as a dup.