1668137 - VO cursor goes into link's text leafs with VO next

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

STR:

1. Load data:text/html,<div><a href="a">one</a></div><div><a href="b">two</a></div><div><a href="c">three</a></div>
2. Press VO+Right repeatedly

Result:
VO cursor goes to link, and then to link's text leaf

Expected:
VO cursor should go to the next link and not go to the text leaf

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1668137 - Use search root for rule's aDirectDescendantsFrom argument. r?morgan!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c62dd862ae3
Use search root for rule's aDirectDescendantsFrom argument. r=morgan

Comment 3

[Atila Butkovits]

Backed out for build bustage on MOXSearchInfo.mm.

Backout link: https://hg.mozilla.org/integration/autoland/rev/858ebc3918cf3d030caea262416d90bb5a26cec1

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=05c9cc6dd872d4cd658aab882bb96fa7d8dbbd0d&searchStr=build&selectedTaskRun=XYmb4kuSRBuzH51AZEPS6w.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317343578&repo=autoland&lineNumber=10979

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8516f1e71977
Use search root for rule's aDirectDescendantsFrom argument. r=morgan

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8516f1e71977

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1668137 - Use search root for rule's aDirectDescendantsFrom argument. r=morgan!

Depends on D92796

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 9180222 [details]
Bug 1668137 - Use search root for rule's aDirectDescendantsFrom argument. r=morgan!

Beta/Release Uplift Approval Request

• User impact if declined: VoiceOver cursor will not work well in many sites
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This isn't a small change, but it has tests and has been verified.
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Is this a new issue? Nothing in this bug suggests it's a regression and given how late we are in the cycle I'm not sure it would qualify for uplift if not.

Comment 9

[Eitan Isaacson [:eeejay]]

Yes, this bug is regressed by bug 1657418.

Comment 10

[Eitan Isaacson [:eeejay]]

Since it is late in the cycle, and VoiceOver support in mac is still experimental, I think it is fine if this is declined beta.

Comment 11

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9180222 [details]
Bug 1668137 - Use search root for rule's aDirectDescendantsFrom argument. r=morgan!

let's let it ride 83 then, thanks