1668265 - Highlighter breaks while refreshing page

Greg Tatum [:gregtatum] (REO Fx132)

Reporter

Description

•

4 years ago

Steps to reproduce:

Go to gregtatum.com
Use the inspect element button to inspect the "programming is poetry" graphic.
Mouse over the tag in the inspector, this will show the box layout highlighter on the page.
Repeatedly refresh the page while inspecting the element.

Expected results:

The highlighter should continue to highlight the element, margins, and paddings.

Actual results:

The highlighter disappears forever on the page. The only way to get it back is to close the tab, and re-open.
No errors appear in the browser console.

I can reproduce this on 81 and 82 on macOS.

I get the following error on Nightly:

Error: Unexpected packet null, {"from":"server1.conn0.windowGlobal15032385539/frameTarget1","error":"noSuchActor","message":"No such actor for ID: server1.conn0.windowGlobal15032385539/frameTarget1"}
    onPacket resource://devtools/shared/protocol/Front.js:320
    onPacket resource://devtools/client/devtools-client.js:492
    send resource://devtools/shared/transport/local-transport.js:68
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
Front.js:321:15

Error: Unexpected packet null, {"from":"server1.conn0.windowGlobal15032385539/frameTarget1","error":"noSuchActor","message":"No such actor for ID: server1.conn0.windowGlobal15032385539/frameTarget1"}
    onPacket resource://devtools/shared/protocol/Front.js:320
    onPacket resource://devtools/client/devtools-client.js:492
    send resource://devtools/shared/transport/local-transport.js:68
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
ThreadSafeDevToolsUtils.js:82:13

However, I get this error only when the "Multiprocess Browser Console" is open, so I don't know if it's related.

Greg Tatum [:gregtatum] (REO Fx132)

Reporter

Comment 1

•

4 years ago

This may also be what folks are reporting in Bug 1352121. However, those steps to reproduce seemed rather old, so I filed a new bug.

Greg Tatum [:gregtatum] (REO Fx132)

Reporter

Comment 2

•

4 years ago

Here is a profile with a high sampling rate of me reproducing the issue. I zoomed in to where it breaks:

https://share.firefox.dev/3mY80Bg

The most interesting stack looks like:

AutoRefreshHighlighter
BoxModelHighlighter
_createHighlighter
_onNavigate
bound
_emit
emit
emit
_navigate
DebuggerProgressListener.prototype.onStateChange<
exports.makeInfallible/<
XPCWrappedJS method call

You can also see the screenshot timeline to see the issue reproduced.

Jan Honza Odvarko [:Honza] (always need-info? me)

Comment 3

•

4 years ago

I can reproduce the issue as well (Win10, current Nightly), no Fission

I am also seeing the following in the Browser Console:

Error while detaching the browsing context target: Error: Connection closed, pending request to server1.conn0.windowGlobal2147483649/frameTarget1, type detach failed

Request stack:
request@resource://devtools/shared/protocol/Front.js:274:14
generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:46:19
detach@resource://devtools/client/fronts/targets/browsing-context.js:118:19
_destroyTarget@resource://devtools/client/fronts/targets/target-mixin.js:683:22
async*destroy@resource://devtools/client/fronts/targets/target-mixin.js:628:12
destroy@resource://devtools/client/fronts/targets/browsing-context.js:129:27
_emit@resource://devtools/shared/event-emitter.js:226:34
emit@resource://devtools/shared/event-emitter.js:172:18
emit@resource://devtools/shared/event-emitter.js:324:18
onPacket@resource://devtools/shared/protocol/Front.js:312:13
onPacket@resource://devtools/client/devtools-client.js:492:13
send/<@resource://devtools/shared/transport/local-transport.js:68:25
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
    purgeRequestsForDestroy resource://devtools/shared/protocol/Front.js:98
    purgeRequests resource://devtools/client/devtools-client.js:693
    onPacket resource://devtools/client/devtools-client.js:484
    send resource://devtools/shared/transport/local-transport.js:68
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
target-mixin.js:722:15
Error: Unexpected packet null, {"from":"server1.conn0.windowGlobal2147483649/frameTarget1","error":"noSuchActor","message":"No such actor for ID: server1.conn0.windowGlobal2147483649/frameTarget1"}
    onPacket resource://devtools/shared/protocol/Front.js:320
    onPacket resource://devtools/client/devtools-client.js:492
    send resource://devtools/shared/transport/local-transport.js:68
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
Front.js:321:15
Error: Unexpected packet null, {"from":"server1.conn0.windowGlobal2147483649/frameTarget1","error":"noSuchActor","message":"No such actor for ID: server1.conn0.windowGlobal2147483649/frameTarget1"}
    onPacket resource://devtools/shared/protocol/Front.js:320
    onPacket resource://devtools/client/devtools-client.js:492
    send resource://devtools/shared/transport/local-transport.js:68
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103

Razvan Caliman [:rcaliman]

Assignee

Updated

•

4 years ago

Severity: -- → S3

Component: Inspector → Inspector : Highlighters

Priority: -- → P2

Razvan Caliman [:rcaliman]

Assignee

Updated

•

4 years ago

Updated

•

4 years ago

Assignee: nobody → rcaliman

Status: NEW → ASSIGNED

Razvan Caliman [:rcaliman]

Assignee

Comment 6

•

4 years ago

Attached file Bug 1668265 - [devtools] Ensure node picker reacts to inspector fronts as they become available or destroyed — Details

Razvan Caliman [:rcaliman]

Assignee

Updated

•

4 years ago

Priority: P2 → P1

Jan Honza Odvarko [:Honza] (always need-info? me)

Comment 9

•

4 years ago

I tested the attached patch and the highlighter continues working even after page refresh (I am following STRs from the comment #0)

Thanks Razvan!

Honza

Razvan Caliman [:rcaliman]

Assignee

Comment 10

•

4 years ago

Comment on attachment 9180189 [details]
Bug 1668265 - [devtools] Ensure node picker reacts to inspector fronts as they become available or destroyed

Beta/Release Uplift Approval Request

User impact if declined: The DevTools node picker stops responding after reloading the page while the tool is active.
Users are unable to use the node picker again until they restart DevTools.

This is disruptive for web developers who use a live reload script or hot module reloading, both popular approaches, to automatically see their changes applied to the page.

This fixes a regression introduced by Bug 1607756.

Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: No
Needs manual test from QE?: No
If yes, steps to reproduce: This is already covered by an automated test. But manual verification can be done following these steps:

Steps to test:

Open http://techno-barje.fr/fission/wiki-n-ubuntu/
Open DevTools and click the node picker icon (upper left corner)
Move the mouse over the page and see nodes get highlighted
Without clicking to pick a node, refresh the page (click the refresh icon next to the address bar)
Continue mousing over the page after refresh

Expected result:
Nodes continue to be highlighted until you click to pick one.

List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Restores functionality that used to work prior to Firefox 81.
The change is isolated to the DevTools node picker code and is covered by a new automated test.
String changes made/needed:

Attachment #9180189 - Flags: approval-mozilla-beta?

Razvan Caliman [:rcaliman]

Assignee

Updated

•

4 years ago

Regressed by: 1607756

BMO Automation

Updated

•

4 years ago

Has Regression Range: --- → yes

Razvan Caliman [:rcaliman]

Assignee

Updated

•

4 years ago

No longer blocks: 1014279

Razvan Caliman [:rcaliman]

Assignee

Updated

•

4 years ago

Blocks: 1670012

Pulsebot

Comment 11

•

4 years ago

Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/553b8374fcc2 [devtools] Ensure node picker reacts to inspector fronts as they become available or destroyed r=ochameau

Cosmin Sabou [:CosminS]

Comment 12

•

4 years ago

Backed out for devtools failures on browser_keybindings_1.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=553b8374fcc2972b2da22669c235482bba17bcbc&selectedTaskRun=ASl1tkZoSGqdvjEIMxUaGA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=318078394&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/ae150ace96dc146f5803ea090e981d4249152028

Flags: needinfo?(rcaliman)

Razvan Caliman [:rcaliman]

Assignee

Comment 13

•

4 years ago

We had a flaky test, devtools/client/framework/test/browser_keybindings_01.js
Rewritten, try looks good. Attempting to land again.

Flags: needinfo?(rcaliman)

Pulsebot

Comment 14

•

4 years ago

Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/60dcec0bfd31 [devtools] Ensure node picker reacts to inspector fronts as they become available or destroyed r=ochameau

Narcis Beleuzu [:NarcisB]

Comment 15

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/60dcec0bfd31

Status: ASSIGNED → RESOLVED

Closed: 4 years ago

status-firefox83: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 83 Branch

Julien Cristau [:jcristau]

Updated

•

4 years ago

Flags: qe-verify+

Julien Cristau [:jcristau]

Comment 16

•

4 years ago

Comment on attachment 9180189 [details]
Bug 1668265 - [devtools] Ensure node picker reacts to inspector fronts as they become available or destroyed

devtools regression fix, approved for 82 rc1

Attachment #9180189 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Julien Cristau [:jcristau]

Comment 17

•

4 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/ce34905a6d52

status-firefox82: --- → fixed

Flags: in-testsuite+

tomliv

Comment 18

•

4 years ago

I am having this issue as well, FF Developer Edition 82.0b9. It seems random to me. I have a video of it but not seeing a way to upload the vid here.

Razvan Caliman [:rcaliman]

Assignee

Comment 19

•

4 years ago

(In reply to Julien Cristau [:jcristau] from comment #17)

https://hg.mozilla.org/releases/mozilla-beta/rev/ce34905a6d52

Thank you very much for picking this up to 82 rc1! Really appreciated!

(In reply to tomliv from comment #18)

I am having this issue as well, FF Developer Edition 82.0b9. It seems random to me. I have a video of it but not seeing a way to upload the vid here.

The issue has been fixed. An uplift will happen soon and will arrive to Firefox Beta and DevEdition within a day or two.

Julien Cristau [:jcristau]

Comment 20

•

4 years ago

Note it won't be in DevEdition until next week's 83.0b1

tomliv

Comment 21

•

4 years ago

I'll keep an eye out. Thanks!

tomliv

Comment 22

•

4 years ago

Just an FYI for anyone coming across this in the meantime, I am able to get it working again by closing the Inspector and reopening. No need to close the whole tab.

Mihai Boldan, Desktop QA [:mboldan]

Updated

•

4 years ago

QA Whiteboard: [qa-triaged]

Razvan Caliman [:rcaliman]

Assignee

Comment 23

•

4 years ago

(In reply to Julien Cristau [:jcristau] from comment #20)

Note it won't be in DevEdition until next week's 83.0b1

Thanks for the clarification, Julien!

Tested the latest Firefox Beta 82. The patch has been applied and the bug is fixed there.

Oana Botisan, Desktop QA

Comment 24

•

4 years ago

I managed to reproduce the issue on an older version of Nightly (2020-09-30) usinf Windows 10 x64.
I retested everything using latest NIghtly 83.0a1 and Firefox 82.0 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.15. The issue is not reproducing anymore.

Status: RESOLVED → VERIFIED

status-firefox82: fixed → verified

status-firefox83: fixed → verified

Flags: qe-verify+

BugBot [:suhaib / :marco/ :calixte]

Updated

•

4 years ago

Keywords: regression

Greg Tatum [:gregtatum] (REO Fx132)

Reporter

Comment 25

•

4 years ago

I can confirm it's fixed for me on Nightly. Thanks for looking into this Razvan!

Rasul

Comment 26

•

4 years ago

Still reproducible for me on Firefox 82.0b9 also with another bug https://youtu.be/hjLbt55AJkg
Steps to reproduce:

Open devtools, hover some DOM elements in inspector or select element with node picker
While hovering DOM elements move cursor quickly out of devtools. Highlighter should highlight any element on the page(this is another bug)
While highlighter still highlights element on the page refresh the page
Selection doesn't work nor with node picker neither with hovering elements in DOM inspector

Ryan VanderMeulen [:RyanVM]

Updated

•

4 years ago

status-firefox-esr78: --- → unaffected

Nobody; OK to take it and work on it

Updated

•

4 years ago

Component: Inspector: Highlighters → Inspector