1668279 - Ensure that changing metrics.yaml cause a rebuild

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Jan-Erik Rediger [:janerik]]

Right now our moz.build only lists a dependency on the metrics_index.py, which itself contains paths to metrics.yaml files.

Changing any of those files should trigger a rebuild of the generated files.
However the build system doesn't see that dependency so doesn't pick it up.

We should find a way to let the build system know of that dependency, either by moving contents of metrics_index.py into moz.build, parsing that file inside moz.build to make dependencies clear or some other way of letting the build system know.

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1668279 - Generate metrics code when any metrics definition file changes r?janerik!

Turns out that metrics_index.py is not only valid Python but is also valid
mozbuild format. So long as our constants are lowercase (uppercase is reserved)
we can include() the index and read the arrays of files to tell
GeneratedFile every file it depends on, not just the index.

We do have to transform the paths, though, as I still maintain that paths
relative to TOPSRCDIR makes more sense for the index, but the inputs to
GeneratedFile are relative to the dir of the moz.build.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f034e46b9723
Generate metrics code when any metrics definition file changes r=janerik

Comment 3

[Atila Butkovits]

Backed outfor build bustage.

Backout link: https://hg.mozilla.org/integration/autoland/rev/647b17e76dd85ea84716a62726b916887bee2c86

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=aIs7ubJgRy6aYlTaeOospA.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=f034e46b9723b4a12f64efd2567b6f223b722f45&searchStr=build

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317311516&repo=autoland&lineNumber=44032

Comment 4

[Chris H-C :chutten]

Huh. Well that was weird. It didn't come up in testing because there were no metrics. And now that there are, the testing strategy of "It doesn't even build" is starting to work : D

Midair collision, already pushed a fix.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c47b32d60be1
Generate metrics code when any metrics definition file changes r=janerik

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for Documentation opt failure

Backout link: https://hg.mozilla.org/integration/autoland/rev/5a724611d28f1e89bb6f7333292cf5f64f9518c5
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317442738&repo=autoland&lineNumber=293

Comment 7

[Chris H-C :chutten]

Oh poo. I see it now. Thank you.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f63a01c189ea
Generate metrics code when any metrics definition file changes r=janerik

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f63a01c189ea