Closed Bug 1668340 Opened 4 years ago Closed 4 years ago

Perma browser_tabKeyBehavior.js | Found one-off button for search mode - "undefined" == true - JS frame :: resource://testing-common/UrlbarTestUtils.jsm :: enterSearchMode :: line 567 when Gecko 83 merges to Beta on 2020-10-19

Categories

(Firefox :: Address Bar, defect, P2)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
83 Branch
Iteration:
83.1 - Sept 21 - Oct 4
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox81 --- unaffected
firefox82 --- unaffected
firefox83 --- verified

People

(Reporter: aryx, Assigned: bugzilla)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1668340 - Fix browser_tabKeyBehavior.js on Beta. r?adw,mak
47 bytes, text/x-phabricator-request
Details | Review

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=ev788XJPS12Q2bRqKe3VfQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=a26b9792ddace03c09e54fb289c3946b5086b92c

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=317167915&repo=try

[task 2020-09-30T14:49:44.568Z] 14:49:44 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_tabKeyBehavior.js | One-offs are visible - true == true -
[task 2020-09-30T14:49:44.569Z] 14:49:44 INFO - Buffered messages finished
[task 2020-09-30T14:49:44.569Z] 14:49:44 INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_tabKeyBehavior.js | Found one-off button for search mode - "undefined" == true - JS frame :: resource://testing-common/UrlbarTestUtils.jsm :: enterSearchMode :: line 567
[task 2020-09-30T14:49:44.570Z] 14:49:44 INFO - Stack trace:
[task 2020-09-30T14:49:44.570Z] 14:49:44 INFO - resource://testing-common/UrlbarTestUtils.jsm:enterSearchMode:567
[task 2020-09-30T14:49:44.571Z] 14:49:44 INFO - Not taking screenshot here: see the one that was previously logged

Flags: needinfo?(htwyford)
Assignee: nobody → htwyford
Blocks: urlbar-searchshortcuts
Severity: -- → S4
Status: NEW → ASSIGNED
Iteration: --- → 83.1 - Sept 21 - Oct 4
Points: --- → 1
Flags: needinfo?(htwyford)
Priority: -- → P2
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00e795e5aeb1
Fix browser_tabKeyBehavior.js on Beta. r=adw

https://hg.mozilla.org/mozilla-central/rev/00e795e5aeb1

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

Verified fixed in yesterday's central-as-beta simulation.

Status: RESOLVED → VERIFIED
status-firefox83: fixed → verified
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: