Fix inline notifications background color on Dark mode
Categories
(Thunderbird :: Theme, defect, P1)
Tracking
(thunderbird_esr68 unaffected, thunderbird_esr78+ fixed, thunderbird81 affected, thunderbird82 fixed, thunderbird83 affected, thunderbird_esr128 verified)
People
(Reporter: aleca, Assigned: aleca)
Details
Attachments
(2 files)
|
11.72 KB,
image/png
|
Details | |
|
1011 bytes,
patch
|
Paenglab
:
review+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
Security pane.png
The inlineNotification.css file comes with hard-coded background colours for error and success variations.
These colours don't play well with the Dark theme, making the whole notification completely unreadable.
My bad, fix coming through.
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9178879 [details] [diff] [review]
1668410-inline-notifications.diff
Yes, a lower specificity for the color rule is better.
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Updated•6 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f4f6378c4071
Fix inline notification background colors for dark mode. r=Paenglab
|
||
Updated•6 years ago
|
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9178879 [details] [diff] [review]
1668410-inline-notifications.diff
[Approval Request Comment]
Safe openpgp darkmode polish
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9178879 [details] [diff] [review]
1668410-inline-notifications.diff
[Triage Comment]
Approved for beta
|
||
Comment 6•6 years ago
|
||
| bugherder uplift | ||
Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/c5df1ee1c181
|
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9178879 [details] [diff] [review]
1668410-inline-notifications.diff
[Triage Comment]
Approved for esr78
|
|
||
Comment 8•6 years ago
|
||
| bugherder uplift | ||
Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/ef9443c431b7
|
||
Comment 9•2 years ago
|
||
Confirming this issue as verified fixed on macOS 14 using ESR 128.0(20240703144221).
Description
•