1668515 - [macos] Save to PDF in the system print dialog defaults filename to Untitled.pdf

Status: RESOLVED WORKSFORME

(Thunderbird :: OS Integration, defect)

Description

[firestormx2k]

Attachment: Screenshot 2020-10-01 at 14.26.18.jpg

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

Selected e-mail from main Thunderbird window/my email list -> clicked on "File-Print..." or entered CMD+P -> clicked on "PDF->Save as PDF"

Actual results:

In the following "Save as" dialogue, the suggested PDF title always defaults to "Untitled.pdf"

Expected results:

The actual subject/ title of the e-mail should be suggested as the title of the PDF file.

Comment 1

[Jonathan Watt [:jwatt]]

Thunderbird may just need an equivalent to the Firefox patch in bug 1664332. That is, set .toFileName (or failing that, .title) on the nsIPrintSettings object that is passed to the code that opens the print dialog.

Comment 2

[Wayne Mery (:wsmwk)]

see comment 1

Comment 3

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #2)

see comment 1

Trying to port the one-liner patch may not be a problem, but...

• Is this a MAC-OS feature? Am failing to find "PDF --> Save to PDF" as a native option on Windows print dialog (There's Microsoft Print to PDF which ends up with a blank file name, maybe that could be fixed, too?).
• Patch of Bug 1664332 is https://phabricator.services.mozilla.com/D89838, which is in fact fixing toolkit/components/printing/content/print.js. So if it's a toolkit change, I think it will come automatically to Thunderbird, no?

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to Thomas D. (:thomas8) from comment #3)

(In reply to Wayne Mery (:wsmwk) from comment #2)

see comment 1

Trying to port the one-liner patch may not be a problem, but...

• Is this a MAC-OS feature? Am failing to find "PDF --> Save to PDF" as a native option on Windows print dialog (There's Microsoft Print to PDF which ends up with a blank file name, maybe that could be fixed, too?).

Perhaps nomis101 or Albert or Antony will know.

• Patch of Bug 1664332 is https://phabricator.services.mozilla.com/D89838, which is in fact fixing toolkit/components/printing/content/print.js. So if it's a toolkit change, I think it will come automatically to Thunderbird, no?

should

Comment 5

[Albert Scheiner [:alberts]]

Is this a MAC-OS feature?

I am very sure it is

Comment 6

[Steve Chessin]

I use MacOS 10.9.5. With TB 68.1.1 and prior, selecting File->Print (or doing a command-P), and then in the Print dialog selecting PDF->Save as PDF..., the Save As: field would be pre-populated with the contents of the Subject: header of the email (and .pdf added). In TB 78.5.1 and 78.6.0, it is pre-populated with Untitled.pdf. (For whatever reason, my upgrade from 68.1.1 took me to 78.5.1, skipping over intervening releases.)

So this is a regression.

Comment 7

[Steve Chessin]

I don't know if this will help, but I did notice two things:

1. If, instead of PDF->Save as PDF..., I select PDF->Open PDF in Preview, Preview titles the window in which it displays the email with the contesnts of the email's Subject: header.

2. When I perform a similar action in Firefox 78.0.2 (File->Print or Command-P, and then PDF->Save as PDF...), Firefox pre-populates the Save As: field with the same string I see if I hover the mouse over the tab of the tab, and that I see if I click on Window and see the name Firefox gives to the current window.

Comment 8

[MZ]

After 5 months, this bug still has: Status: UNCONFIRMED, Priority: Not set, Severity: --

Saving an email as PDF is a frequent action for some users. Having to manually copy & paste a subject line before saving an email is an annoying defect that spoils any positive user experience of Thunderbird (on MacOS).

What can I contribute to get the Status = CONFIRMED, and something like Priority = 2, Severity = 2 ?

Thanks!

Comment 9

[firestormx2k]

I absolutely agree with MZ. What can we do to get the status to "confirmed" and get this bug fixed?

Comment 10

[Albert Scheiner [:alberts]]

Confirming it. Also confirming the valid workaorund - with one extra step, though - from Steve's comment above:

• cmd + P to print
• PDF -> Open in Preview
• File -> Export

Comment 11

[firestormx2k]

Hmm, thank you, I can indeed confirm the bug, it's still present in version 78.7.1. The workaround "PDF -> Open in Preview -> Save ... / Export ..." seems to work.