1668516 - [PI-819] [old UI] The page orientation can no longer be changed after printing to PDF on Windows

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P1)

Description

[Patriciu Pop [:ppop], Ecosystem QA]

Attachment: print_to_PDF.gif

[Affected versions]:

• Firefox Beta 82.0b5, Build ID 20200929175845

[Affected platforms]:

• Windows 10 x64

[Prerequisites]:

• Have the "print.tab_modal.enabled" pref set as "false".

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites and navigate to any webpage.
2. Click the hamburger menu button and click the "Print..." option.
3. Make sure "Portrait" mode is selected and click the "Print..." button.
4. Select the "Microsoft Print to PDF" and click the "Print" button.
5. After the document is saved, click the "Landscape" button and observe the behavior.

[Expected result]:

• The orientation of the page is changed to Landscape.

[Actual result]:

• The page remains in the Portrait orientation.

[Regression]:

• I have managed to find a regression window, using the Mozregression tool. Here are the results:
  Last good revision: 24648c48a49cc229f8839d19c22fb2626f767c82
  First bad revision: b32cb06ef2aeaa939af0484498fcbfd74db05790
  Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=24648c48a49cc229f8839d19c22fb2626f767c82&tochange=b32cb06ef2aeaa939af0484498fcbfd74db05790
• From the pushlog, it seems that bug 1663940 might have caused this issue.

[Notes]:

• This issue is not reproducible using the new UI.
• The issues persists after the browser is restarted.
• This issue is not reproducible on macOS and linux.
• Attached a screen recording of the issue:

Comment 1

[:Gijs (he/him)]

Bob, can you take a look?

Comment 2

[Bob Owen (:bobowen)]

Attachment: Bug 1668516: Account for orientation when getting paper size from device context in CopyFromNative. r=jwatt!

Depends on D92099

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80dbcab5c7ca
Account for orientation when getting paper size from device context in CopyFromNative. r=jwatt

Comment 4

[Bob Owen (:bobowen)]

Comment on attachment 9179083 [details]
Bug 1668516: Account for orientation when getting paper size from device context in CopyFromNative. r=jwatt!

Beta/Release Uplift Approval Request

• User impact if declined: Previewing and printing to landscape will be broken for Windows users in the old UI.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See description
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fairly simple patch which allows for whether the DEVMODE and device context being used have their orientation set to landscape.
• String changes made/needed: None

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/80dbcab5c7ca

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9179083 [details]
Bug 1668516: Account for orientation when getting paper size from device context in CopyFromNative. r=jwatt!

approved for 82.0b7

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3d34d7f8839c

Comment 8

[Patriciu Pop [:ppop], Ecosystem QA]

I've verified that this issue is no longer reproducible on Beta 82.0b7, Build ID 20201002191150 and Nightly 83.0a1, Build ID 20201004212809 using Windows 10 x64. However the "Landscape" page orientation can't be selected before printing at least once. This behavior is tracked in Bug 1669187.

Comment 9

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1082851