1669000 - Permafailing devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js:75 - TypeError: can't access property "attac

Status: RESOLVED FIXED

(DevTools :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=317478659&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fq35nqGaQnqiJ8c-yXfsnw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-10-03T13:01:06.081Z] 13:01:06     INFO - TEST-PASS | devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js | front for worker in tab 2 has been closed - 
[task 2020-10-03T13:01:06.081Z] 13:01:06     INFO - Listing workers.
[task 2020-10-03T13:01:06.082Z] 13:01:06     INFO - Finding worker with url 'code_WorkerTargetActor.attach-worker1.js'.
[task 2020-10-03T13:01:06.083Z] 13:01:06     INFO - Buffered messages finished
[task 2020-10-03T13:01:06.083Z] 13:01:06     INFO - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js:75 - TypeError: can't access property "attach", workerDescriptorFront1 is null
[task 2020-10-03T13:01:06.084Z] 13:01:06     INFO - Stack trace:
[task 2020-10-03T13:01:06.085Z] 13:01:06     INFO - @chrome://mochitests/content/browser/devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js:75:3
[task 2020-10-03T13:01:06.085Z] 13:01:06     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1069:34
[task 2020-10-03T13:01:06.086Z] 13:01:06     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1109:11
[task 2020-10-03T13:01:06.087Z] 13:01:06     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:932:14
[task 2020-10-03T13:01:06.088Z] 13:01:06     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1037:23
[task 2020-10-03T13:01:06.088Z] 13:01:06     INFO - Leaving test bound 
[task 2020-10-03T13:01:06.089Z] 13:01:06     INFO - Removing tab.
[task 2020-10-03T13:01:06.090Z] 13:01:06     INFO - Tab removed and finished closing.
[task 2020-10-03T13:01:06.090Z] 13:01:06     INFO - TEST-PASS | devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2020-10-03T13:01:06.091Z] 13:01:06     INFO - GECKO(10846) | MEMORY STAT | vsize 2892MB | residentFast 353MB | heapAllocated 139MB
[task 2020-10-03T13:01:06.092Z] 13:01:06     INFO - TEST-OK | devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js | took 706ms
[task 2020-10-03T13:01:06.093Z] 13:01:06     INFO - checking window state```

Comment 1

[Intermittent Failures Robot]

8 failures in 4195 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 8

Platform breakdown:

• windows10-64-shippable: 4
• linux1804-64-shippable: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1669000&startday=2020-09-28&endday=2020-10-04&tree=all

Comment 2

[Natalia Csoregi [:nataliaCs]]

Update:

There have been 37 failures within the last 7 days:

• 18 failures on Linux 18.04 x64 shippable opt
• 19 failures on Windows 10 x64 Shippable opt

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318226012&repo=mozilla-central&lineNumber=2993

Seems to be permafailing: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=linux%2C18.04%2Cx64%2Cshippable%2Copt%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-shippable%2Fopt-mochitest-devtools-chrome-fis-e10s%2Cdt5&revision=7d7faf0b6d7a7ee76d6685a61f26b4c20a6e5d29

Most probably related to Bug 1668117.

Julian, do you have a few minutes to check? Thank you.

Comment 3

[Intermittent Failures Robot]

37 failures in 4130 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

This is the #34 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 35
• try: 2

Platform breakdown:

• windows10-64-shippable: 19
• linux1804-64-shippable: 18

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1669000&startday=2020-10-05&endday=2020-10-11&tree=all

Comment 4

[Julian Descottes [:jdescottes]]

Thanks for the heads up!
Not related to Bug 1668117 as it already happens with https://hg.mozilla.org/mozilla-central/rev/d548bb7ebca0a5fc219a31e570baa28605837fcd

Will bisect.

Comment 5

[Julian Descottes [:jdescottes]]

Having issues in my bisect due to artifacts. Issue is most likely coming from a C++ change.

I am suspecting https://bugzilla.mozilla.org/show_bug.cgi?id=1668357, since this enabled session-history-in-parent with fission and the issue is related to a missing worker after navigating back. Local tests are providing limited info due to missing artifacts. Pushed with no artifact for more info:

• without SHIP https://treeherder.mozilla.org/#/jobs?repo=try&revision=65baf2e15369e75a066afec3e8afad49b3d6eb13
• with SHIP https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec4275fe39ad5b169b01960e410357919fb11191

Comment 6

[Julian Descottes [:jdescottes]]

I assumed this test should have been skipped for fission in https://phabricator.services.mozilla.com/D91977 but it was missed

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1669000 - [devtools] Add fail-if=fission for browser_dbg_WorkerTargetActor.attach.js

This test perma fails on Fission since session-history-in-parent was enabled.
The test asserts workers retrieved from BrowsingContext targets as follows:

• go to page1, check we can get worker1
• go to page2, check we can get worker2
• go back to page1, check we can get worker1

On the last step, after navigating back, we are unable to retrieve the worker1 on pag1

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc23fd6fc7c2
[devtools] Add fail-if=fission for browser_dbg_WorkerTargetActor.attach.js r=smaug,ochameau

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bc23fd6fc7c2

Comment 10

[Intermittent Failures Robot]

11 failures in 3694 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 11

Platform breakdown:

• linux1804-64-shippable: 5
• windows10-64-shippable: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1669000&startday=2020-10-12&endday=2020-10-18&tree=all