1691588 - Fix and re-enable devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js test for Fission

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Chris Peterson [:cpeterson]]

This test was disabled for Fission in bug 1669000.

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/devtools/client/shared/test/browser.ini#254-256

[browser_dbg_WorkerTargetActor.attach.js]
fail-if = fission # Fails with Fission + session-history-in-parent (Bug 1669000)
skip-if = e10s && debug

Comment 1

[Chris Peterson [:cpeterson]]

Tracking DevTools test bugs for Fission M8 (blocking Release experiment).

Comment 2

[Chris Peterson [:cpeterson]]

Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.

Comment 3

[Alexandre Poirot [:ochameau]]

Unfortunately, these is more than one failure behind this test and one isn't trivial. More info on phabricator.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1691588 - [devtools] Rewrite browser_dbg_WorkerTargetActor.attach.js into a TargetCommand test.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

At least for me the test seems to pass now on Fission. Does it rely on bfcache, which wasn't enabled when the comment 4 was created?
Or perhaps something else has been fixed.
Could we enable the test?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

oh, hmm, now it happened again. nm then.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Some comments from my testing (Nightly, Win10):

1. It seems to pass when running with Fission and BFCache in Parent ON`

I see no failures when running as follows:
$ mach test devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js --enable-fission --setpref fission.bfcacheInParent=true --ve rify --headless

2. Fails for me when running with server side target switching ON devtools.target-switching.server.enabled

$ mach test devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js --enable-fission --setpref devtools.target-switching.server.e nabled=true

0:13.42 INFO Waiting for worker to close.
 0:13.45 GECKO(2300) console.error: (new InvalidStateError("JSWindowActorChild.sendAsyncMessage: JSWindowActorChild cannot send at the moment", (void 0), 370))

3. I also tested workers functionality using my online test case
   http://janodvarko.cz/tests/fission/case15/index.html

• The test page starts two workers when loaded
• There are buttons for stopping and starting these workers again
• The workers are periodically sending a message, which are printed on the page (so, it's visible if they are alive)

The test case shows that:

• The worker is properly paused when the page is in BFCache [1]
• The worker is properly resumed when the page is loaded from BFCache
• The Threads side panel in DevTools is properly updated when starting/stopping a worker
• The Sources panel doesn't show Worker source files when the page is loaded from BFCache (but this might should be covered by Bug 1717611)

[1] Alex, I can't repro the issue where the worker was running in the cache, probably something wrong on my side when I tested that.

Honza

Comment 8

[Alexandre Poirot [:ochameau]]

This still fails on try with the same exception I mentioned on phabricator:
https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=AR40pQ72S6CfMJcNT8v0bA.0&revision=49183e42d9c18c97e4147fca26df9fa170bca8f0
https://phabricator.services.mozilla.com/D117164#3813272

But I no longer reproduce it easily locally.

Comment 9

[Alexandre Poirot [:ochameau]]

This test started failing some more with bfcache in parent and even more with server side targets (bug 1698891).
It uses BrowsingContextTargetActor.listWorkers and because of that breaks on target switching.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b29cd4b6f3b
[devtools] Rewrite browser_dbg_WorkerTargetActor.attach.js into a TargetCommand test. r=nchevobbe

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5b29cd4b6f3b